feat(snippet-bot): read products from service configs in googleapis/googleapis #5014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: add daily cron to reload products cache
chingor13
commented
Mar 28, 2023
| ): Promise<Array<Violation>> => { | ||
| const ret: Violation[] = []; | ||
| const apiLabels = await getApiLabels(dataBucket, logger); |
There was a problem hiding this comment.
Avoid an implicit API call here -- explicitly provide the list of allowed products. The caller is expected to source the list.
chingor13
changed the title
SurferJeffAtGoogle
suggested changes
Mar 29, 2023
SurferJeffAtGoogle
approved these changes
Mar 29, 2023
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short term solution to merge new products from service_configs in googleapis/googleapis into the exported product list from DKP.
To improve performance, we use a daily cron job to scan googleapis/googleapis for service configs and merge the result with the exported list from DKP.
Fixes #4994
feat: add daily cron to reload products cache
refactor: pass ApiLabels list into violations logic to avoid implicit API call