fix: [auto-approve] add event listener for pull request dismissed #5333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sofisl
changed the title
chingor13
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed in googleapis/nodejs-pubsub#1927 that merge-on-green kept dismissing auto-approve's latest review due to post-processor updates, other commits, etc. Ideally, those commits would retrigger auto-approve to re-review the PR. But there seems to be a race condition where sometimes merge-on-green beats auto-approve to re-approving and dismisses the PR. This fix would allow auto-approve to listen to reviews dismissed, so that it always has a chance to re-review the most recent commit when an
automerge: exactlabel has been placed.As part of this work, the pull_request_review.dismissed event needs to access the pr number through
pull_request.number, so I had to update this for all the events and make sure the test fixtures had the appropriate number there too.Fixes #5096