fix(ast): removed lambda void return type check (#1019)

Fix for Issue #843. This pull request modifies allows the creation of lambda expressions that have void as return type. The main change was made in engine/ast/LambdaExpr.java
googleapis · Aug 2, 2022 · 9d792bc · 9d792bc
1 parent 7712d8c
commit 9d792bc
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 14 deletions.
diff --git a/gapic-generator-java/src/main/java/com/google/api/generator/engine/ast/LambdaExpr.java b/gapic-generator-java/src/main/java/com/google/api/generator/engine/ast/LambdaExpr.java
@@ -67,9 +67,6 @@ public Builder setReturnExpr(Expr expr) {
 
     public LambdaExpr build() {
       LambdaExpr lambdaExpr = autoBuild();
-      Preconditions.checkState(
-          !lambdaExpr.returnExpr().expr().type().equals(TypeNode.VOID),
-          "Lambdas cannot return void-typed expressions.");
       // Must be a declaration.
       lambdaExpr.arguments().stream()
           .forEach(

diff --git a/gapic-generator-java/src/test/java/com/google/api/generator/engine/ast/LambdaExprTest.java b/gapic-generator-java/src/test/java/com/google/api/generator/engine/ast/LambdaExprTest.java
@@ -85,17 +85,16 @@ public void validLambdaExpr_withBody() {
   }
 
   @Test
-  public void invalidLambdaExpr_returnsVoid() {
-    assertThrows(
-        IllegalStateException.class,
-        () ->
-            LambdaExpr.builder()
-                .setReturnExpr(
-                    MethodInvocationExpr.builder()
-                        .setMethodName("foo")
-                        .setReturnType(TypeNode.VOID)
-                        .build())
-                .build());
+  public void validLambdaExpr_returnsVoid() {
+    LambdaExpr voidLambda =
+        LambdaExpr.builder()
+            .setReturnExpr(
+                MethodInvocationExpr.builder()
+                    .setMethodName("foo")
+                    .setReturnType(TypeNode.VOID)
+                    .build())
+            .build();
+    assertEquals(TypeNode.VOID, voidLambda.returnExpr().type());
   }
 
   @Test