Skip to content

Commit

Permalink
[ggj][engx] fix: remove one-use wrapper in SettingsSampleCodeComposer (
Browse files Browse the repository at this point in the history
…#604)

* fix: fix dep ordering in Bazel dedupe rules

* chore:  centralize all Gapic class name getters

* fix: use gapic-remapped names in package-info.java

* fix: revert unrelated changes

* fix: handle back-compat casing for IAMCredentials API

* fix: remove unused package option from integration test rules

* fix: rename StubCommentComposer file to match class name

* fix: refactor SettingsSampleCodeComposer to be more modular

* fix: remove one-use wrapper in SettingsSampleCodeComposer
  • Loading branch information
miraleung authored Dec 17, 2020
1 parent 522e482 commit c95aafb
Showing 1 changed file with 1 addition and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ public static Optional<String> composeSampleCode(Optional<Method> methodOpt, Typ
VariableExpr.withVariable(
Variable.builder()
.setType(classType)
.setName(getServiceSettingsName(className))
.setName(JavaStyle.toLowerCamelCase(className).replace("Stub", ""))
.build());
AssignmentExpr settingBuildAssignmentExpr =
AssignmentExpr.builder()
Expand All @@ -147,10 +147,6 @@ public static Optional<String> composeSampleCode(Optional<Method> methodOpt, Typ
return Optional.of(SampleCodeJavaFormatter.format(writeStatements(statements)));
}

private static String getServiceSettingsName(String className) {
return JavaStyle.toLowerCamelCase(className).replace(STUB, EMPTY_STRING);
}

private static String getClassSettingsBuilderName(String className) {
return JavaStyle.toLowerCamelCase(
String.format(BUILDER_NAME_PATTERN, JavaStyle.toLowerCamelCase(className)))
Expand Down

0 comments on commit c95aafb

Please sign in to comment.