Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The max rpc per channel is set to 100 on GFE, we need to set maxRpcsPerChannel in gax accordingly. #1594

Open
blakeli0 opened this issue Mar 31, 2023 · 0 comments
Open

The max rpc per channel is set to 100 on GFE, we need to set maxRpcsPerChannel in gax accordingly. #1594

blakeli0 opened this issue Mar 31, 2023 · 0 comments
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@blakeli0
Copy link
Collaborator

blakeli0 commented Mar 31, 2023 •
edited
Loading

By default, the number of gRPC channel is set to 1 channel and the max rpc per channel is set to Integer.MAX_VALUE. However, the max rpc per channel is set to 100 on GFE(pending confirmation), if a channel is overloaded and maxRpcsPerChannel is not set, ChannelPool will not resize correctly and would cause performance degradation.

We need to set the default maxRpcsPerChannel to 100, and prevents it from being set to any number that is greater than 100.

We also need to make sure directpath is not affected by this, as directpath doesn't suffer all the same limits as GFEs.
@blakeli0 blakeli0 added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Mar 31, 2023
JoeWang1127 pushed a commit that referenced this issue Apr 11, 2023
@gcf-owl-bot
chore: exclude requirements.txt file from renovate-bot (#1594) (#933)
394f449 
Source-Link: googleapis/synthtool@f58d313
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:f14e3fefe8e361e85752bd9890c8e56f2fe25f1e89cbb9597e4e3c7a429203a3
JoeWang1127 pushed a commit that referenced this issue Apr 11, 2023
@gcf-owl-bot
chore: exclude requirements.txt file from renovate-bot (#1594) (#811)
7ebbe69 
Source-Link: googleapis/synthtool@f58d313
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:f14e3fefe8e361e85752bd9890c8e56f2fe25f1e89cbb9597e4e3c7a429203a3
suztomo pushed a commit to suztomo/gapic-generator-java that referenced this issue May 15, 2023
@gcf-owl-bot
chore: exclude requirements.txt file from renovate-bot (googleapis#1594…
52d5e12 
…) (googleapis#438)

Source-Link: googleapis/synthtool@f58d313
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:f14e3fefe8e361e85752bd9890c8e56f2fe25f1e89cbb9597e4e3c7a429203a3
suztomo pushed a commit to suztomo/gapic-generator-java that referenced this issue May 15, 2023
@gcf-owl-bot
chore: exclude requirements.txt file from renovate-bot (googleapis#1594…
f9150bb 
…) (googleapis#417)

Source-Link: googleapis/synthtool@f58d313
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:f14e3fefe8e361e85752bd9890c8e56f2fe25f1e89cbb9597e4e3c7a429203a3
@blakeli0 blakeli0 added priority: p3 Desirable enhancement or fix. May not be included in next release. and removed priority: p2 Moderately-important priority. Fix may not be included in next release. labels Aug 10, 2023
@blakeli0 blakeli0 added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@blakeli0