Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gapic-generator-java: discrepancy in writers handling deeply nested types #1708

Closed
emmileaf opened this issue May 24, 2023 · 0 comments · Fixed by #1709
Closed

gapic-generator-java: discrepancy in writers handling deeply nested types #1708

emmileaf opened this issue May 24, 2023 · 0 comments · Fixed by #1709
Assignees
@emmileaf
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@emmileaf
Copy link
Contributor

emmileaf commented May 24, 2023 •
edited
Loading

Suppose nested type Outer.Middle.Inner: in some scenarios the generated code will not compile because of nesting level mismatch between type and import:

// from ImportWriterVisitor
import com.google.testgapic.v1beta1.Outer.Middle; 

// from JavaWriterVisitor
Outer.Middle.Inner myVariable;

There are possibly other discrepancies with nested class handling (e.g. for ConcreteReference vs. VaporReference) to be investigated. (See f505036 for additional tests illustrating unintended behavior)
@emmileaf emmileaf added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels May 24, 2023
@emmileaf emmileaf self-assigned this May 24, 2023
@emmileaf emmileaf mentioned this issue May 24, 2023
Merged
lqiu96 pushed a commit that referenced this issue Jun 8, 2023
@gcf-owl-bot
chore: use gcp-docuploader 0.6.3 (#1708) (#1027)
468f7a9 
Source-Link: googleapis/synthtool@fbc8bfe
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:e76136cc48f90aa19ba29cdfbd4002111467e44a1c9d905867d98dafafbd03bb

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
lqiu96 pushed a commit that referenced this issue Jun 8, 2023
@gcf-owl-bot
chore: use gcp-docuploader 0.6.3 (#1708) (#913)
ec3025e 
Source-Link: googleapis/synthtool@fbc8bfe
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:e76136cc48f90aa19ba29cdfbd4002111467e44a1c9d905867d98dafafbd03bb

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emmileaf emmileaf

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: [gapic-generator-java] align writer behavior for nested types googleapis/sdk-platform-java
1 participant
@emmileaf