Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FR: expose a getter for ChannelPoolSettings in InstantiatingGrpcChannelProvider #2610

Closed
ehsannas opened this issue Mar 28, 2024 · 1 comment · Fixed by #2612
Closed

FR: expose a getter for ChannelPoolSettings in InstantiatingGrpcChannelProvider #2610

ehsannas opened this issue Mar 28, 2024 · 1 comment · Fixed by #2612
Assignees
@lqiu96
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@ehsannas
Copy link
Contributor

Is your feature request related to a problem? Please describe.
We'd like to have observability (e.g. through logs or traces) of the grpc channel pool settings. This can help identify potential misconfiguration of clients by customers.

Describe the solution you'd like
Expose a getter for ChannelPoolSettings in InstantiatingGrpcChannelProvider

Additional context
b/323070915
@blakeli0 blakeli0 added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Mar 28, 2024
@lqiu96 lqiu96 self-assigned this Mar 28, 2024
@lqiu96 lqiu96 mentioned this issue Mar 28, 2024
Merged
lqiu96 added a commit that referenced this issue Apr 2, 2024
@lqiu96 @JoeWang1127
feat: Add ChannelPoolSettings Getter for gRPC's ChannelProvider (#2612)
d0c5191 
Fixes #2610 ☕️

---------

Co-authored-by: Joe Wang <106995533+JoeWang1127@users.noreply.github.com>
@ehsannas
Copy link
Contributor Author

ehsannas commented Apr 2, 2024

Thanks @lqiu96 !

lqiu96 added a commit that referenced this issue Apr 2, 2024
@lqiu96 @JoeWang1127
feat: Add ChannelPoolSettings Getter for gRPC's ChannelProvider (#2612)
9812585 
Fixes #2610 ☕️

---------

Co-authored-by: Joe Wang <106995533+JoeWang1127@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lqiu96 lqiu96

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add ChannelPoolSettings Getter for gRPC's ChannelProvider googleapis/sdk-platform-java
3 participants
@ehsannas @blakeli0 @lqiu96