Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update environment variable unit tests with Junit 5 features. #2785

Closed
blakeli0 opened this issue May 17, 2024 · 0 comments · Fixed by #2799
Closed

Update environment variable unit tests with Junit 5 features. #2785

blakeli0 opened this issue May 17, 2024 · 0 comments · Fixed by #2799
Assignees
@JoeWang1127
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.

Comments

@blakeli0
Copy link
Collaborator

We currently have a few environment variable unit tests achieved by Maven profiles due to Junit 4 does not support setting environment variables. Now that we added Junit 5, we should update these tests with Junit 5 features.
See #2724 (comment) for details.
@blakeli0 blakeli0 added type: cleanup An internal cleanup or hygiene concern. priority: p2 Moderately-important priority. Fix may not be included in next release. labels May 17, 2024
@JoeWang1127 JoeWang1127 self-assigned this May 22, 2024
This was referenced May 22, 2024
Closed
Merged
JoeWang1127 added a commit that referenced this issue May 23, 2024
@JoeWang1127
chore: add junit5 extension to setup environment variable (#2799)
599f5da 
Fix: #2785.
@release-please release-please bot mentioned this issue May 23, 2024
Closed
lqiu96 pushed a commit that referenced this issue May 23, 2024
@JoeWang1127 @lqiu96
chore: add junit5 extension to setup environment variable (#2799)
7b494c6 
Fix: #2785.
@release-please release-please bot mentioned this issue May 24, 2024
Merged
diegomarquezp pushed a commit that referenced this issue May 31, 2024
@release-please
chore(main): release 2.41.0 (#2820)
317f472 
🤖 I have created a release *beep* *boop*
---


<details><summary>2.41.0</summary>

##
[2.41.0](v2.40.1...v2.41.0)
(2024-05-31)


### Features

* add a github client
([#2747](#2747))
([f8ea0a0](f8ea0a0))
* generate proto-only repository
([#2720](#2720))
([f7a5161](f7a5161))


### Bug Fixes

* [#2785](#2785).
([599f5da](599f5da))


### Dependencies

* update dependency com.google.api-client:google-api-client-bom to
v2.6.0
([#2782](#2782))
([5bc8928](5bc8928))
* update dependency
com.google.cloud.opentelemetry:detector-resources-support to v0.29.0
([#2831](#2831))
([6c1dbfc](6c1dbfc))
* update dependency com.google.code.gson:gson to v2.11.0
([#2786](#2786))
([91f3254](91f3254))
* update dependency com.google.code.gson:gson to v2.11.0
([#2787](#2787))
([e81893c](e81893c))
* update dependency com.google.errorprone:error_prone_annotations to
v2.28.0
([#2835](#2835))
([b8f11b1](b8f11b1))
* update dependency com.google.errorprone:error_prone_annotations to
v2.28.0
([#2838](#2838))
([5c46f3f](5c46f3f))
* update dependency net.bytebuddy:byte-buddy to v1.14.16
([#2797](#2797))
([dfedafc](dfedafc))
* update dependency net.bytebuddy:byte-buddy to v1.14.17
([#2828](#2828))
([6eb9041](6eb9041))
* update dependency org.checkerframework:checker-qual to v3.43.0
([#2730](#2730))
([b7fa736](b7fa736))
* update dependency requests to v2.32.0 [security]
([#2791](#2791))
([c2ea6cc](c2ea6cc))
* update dependency watchdog to v4.0.1
([#2800](#2800))
([d5771dd](d5771dd))
* update google api dependencies
([#2672](#2672))
([6643536](6643536))
* update google http client dependencies to v1.44.2
([#2783](#2783))
([dee7e00](dee7e00))
* update googleapis/java-cloud-bom digest to 59c776b
([#2827](#2827))
([03b3eb4](03b3eb4))
* update netty dependencies to v4.1.110.final
([#2796](#2796))
([d1aaa68](d1aaa68))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
lqiu96 pushed a commit that referenced this issue Jun 10, 2024
@release-please @lqiu96
chore(main): release 2.41.0 (#2820)
8531102 
🤖 I have created a release *beep* *boop*
---


<details><summary>2.41.0</summary>

##
[2.41.0](v2.40.1...v2.41.0)
(2024-05-31)


### Features

* add a github client
([#2747](#2747))
([f8ea0a0](f8ea0a0))
* generate proto-only repository
([#2720](#2720))
([f7a5161](f7a5161))


### Bug Fixes

* [#2785](#2785).
([599f5da](599f5da))


### Dependencies

* update dependency com.google.api-client:google-api-client-bom to
v2.6.0
([#2782](#2782))
([5bc8928](5bc8928))
* update dependency
com.google.cloud.opentelemetry:detector-resources-support to v0.29.0
([#2831](#2831))
([6c1dbfc](6c1dbfc))
* update dependency com.google.code.gson:gson to v2.11.0
([#2786](#2786))
([91f3254](91f3254))
* update dependency com.google.code.gson:gson to v2.11.0
([#2787](#2787))
([e81893c](e81893c))
* update dependency com.google.errorprone:error_prone_annotations to
v2.28.0
([#2835](#2835))
([b8f11b1](b8f11b1))
* update dependency com.google.errorprone:error_prone_annotations to
v2.28.0
([#2838](#2838))
([5c46f3f](5c46f3f))
* update dependency net.bytebuddy:byte-buddy to v1.14.16
([#2797](#2797))
([dfedafc](dfedafc))
* update dependency net.bytebuddy:byte-buddy to v1.14.17
([#2828](#2828))
([6eb9041](6eb9041))
* update dependency org.checkerframework:checker-qual to v3.43.0
([#2730](#2730))
([b7fa736](b7fa736))
* update dependency requests to v2.32.0 [security]
([#2791](#2791))
([c2ea6cc](c2ea6cc))
* update dependency watchdog to v4.0.1
([#2800](#2800))
([d5771dd](d5771dd))
* update google api dependencies
([#2672](#2672))
([6643536](6643536))
* update google http client dependencies to v1.44.2
([#2783](#2783))
([dee7e00](dee7e00))
* update googleapis/java-cloud-bom digest to 59c776b
([#2827](#2827))
([03b3eb4](03b3eb4))
* update netty dependencies to v4.1.110.final
([#2796](#2796))
([d1aaa68](d1aaa68))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoeWang1127 JoeWang1127

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
2 participants
@blakeli0 @JoeWang1127