Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ServiceManager's HttpJson Tests fails for IAM RPC Callables #1839

Open
lqiu96 opened this issue Jul 10, 2023 · 2 comments · May be fixed by #2840
Open

ServiceManager's HttpJson Tests fails for IAM RPC Callables #1839

lqiu96 opened this issue Jul 10, 2023 · 2 comments · May be fixed by #2840
Assignees
@lqiu96
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@lqiu96
Copy link
Contributor

lqiu96 commented Jul 10, 2023

Error:

2023-07-10T15:19:26.5433019Z 15:19:26:539 [ERROR] Errors: 
2023-07-10T15:19:26.5436045Z 15:19:26:539 [ERROR]   ServiceManagerClientHttpJsonTest.getIamPolicyTest:900 » NotFound com.google.api.client.http.HttpResponseException: 404
2023-07-10T15:19:26.5437373Z POST https://servicemanagement.googleapis.com:443/v1/GetIamPolicyRequest-1527610370:getIamPolicy?$alt=json;enum-encoding%3Dint
2023-07-10T15:19:26.5438254Z Method not found for path 'https:///v1/GetIamPolicyRequest-1527610370:getIamPolicy'
2023-07-10T15:19:26.5439405Z 15:19:26:539 [ERROR]   ServiceManagerClientHttpJsonTest.setIamPolicyTest:844 » NotFound com.google.api.client.http.HttpResponseException: 404
2023-07-10T15:19:26.5440341Z POST https://servicemanagement.googleapis.com:443/v1/SetIamPolicyRequest1223629066:setIamPolicy?$alt=json;enum-encoding%3Dint
2023-07-10T15:19:26.5441076Z Method not found for path 'https:///v1/SetIamPolicyRequest1223629066:setIamPolicy'
2023-07-10T15:19:26.5441895Z 15:19:26:539 [ERROR]   ServiceManagerClientHttpJsonTest.testIamPermissionsTest:950 » NotFound com.google.api.client.http.HttpResponseException: 404
2023-07-10T15:19:26.5442821Z POST https://servicemanagement.googleapis.com:443/v1/TestIamPermissionsRequest942398222:testIamPermissions?$alt=json;enum-encoding%3Dint
2023-07-10T15:19:26.5443539Z Method not found for path 'https:///v1/TestIamPermissionsRequest942398222:testIamPermissions'

Seen in: googleapis/google-cloud-java#9583

This might be due to a mismatch between the IAM Request's Resource and IAM callable's path. Might be a generator or proto issue, but will need to be debugged.
@lqiu96 lqiu96 added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jul 10, 2023
@lqiu96 lqiu96 mentioned this issue Jul 10, 2023
Merged
1 task
@lqiu96
Copy link
Contributor Author

lqiu96 commented Jul 19, 2023

googleapis/google-cloud-java#9583 (comment)

We have decided to ignore these test cases for now.

@lqiu96 lqiu96 mentioned this issue Aug 2, 2023
Merged
1 task
@diegomarquezp diegomarquezp mentioned this issue Sep 25, 2023
Merged
1 task
diegomarquezp added a commit to googleapis/google-cloud-java that referenced this issue Sep 25, 2023
@diegomarquezp
ignore faulty tests
9b5467f 
Context in googleapis/sdk-platform-java#1839
@lqiu96 lqiu96 self-assigned this Nov 8, 2023
@lqiu96 lqiu96 added priority: p3 Desirable enhancement or fix. May not be included in next release. and removed priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jan 8, 2024
@suztomo suztomo mentioned this issue Jan 9, 2024
Merged
1 task
@JoeWang1127 JoeWang1127 mentioned this issue Feb 5, 2024
Merged
1 task
@alicejli alicejli mentioned this issue Feb 19, 2024
Merged
1 task
This was referenced Mar 14, 2024
Merged
Merged
@JoeWang1127
Copy link
Collaborator

Once this issue is fixed, we should revert changes made in googleapis/google-cloud-java#10539 and googleapis/google-cloud-java#10543 to restore these unit tests.

@blakeli0 blakeli0 added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed priority: p3 Desirable enhancement or fix. May not be included in next release. labels May 14, 2024
@lqiu96 lqiu96 linked a pull request May 31, 2024 that will close this issue
Open
This was referenced Aug 20, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lqiu96 lqiu96

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: HttpJson tests generate request for Mixins with custom paths googleapis/sdk-platform-java
3 participants
@blakeli0 @lqiu96 @JoeWang1127