Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ~ separated resource names #449

Closed
nwbirnie opened this issue Nov 3, 2020 · 1 comment
Closed

Add support for ~ separated resource names #449

nwbirnie opened this issue Nov 3, 2020 · 1 comment
Assignees

Comments

@nwbirnie
Copy link

nwbirnie commented Nov 3, 2020

In ads API, we use resource names which contain ~ to delimit multiple IDs in a path segment. For example:

message AdGroupAd {
  option (google.api.resource) = {
    type: "googleads.googleapis.com/AdGroupAd"
    pattern: "customers/{customer_id}/adGroupAds/{ad_group_id}~{ad_id}"
  };

The current microgenerator implementation doesn't appear to support this, and instead just generates a single param in its place.

Link to protos: http://shortn/_zIPrXkqkoU

@miraleung miraleung self-assigned this Nov 24, 2020
@miraleung
Copy link
Contributor

miraleung commented Nov 24, 2020

Fixed in #450

suztomo pushed a commit that referenced this issue Dec 16, 2022
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [google-crc32c](https://togithub.com/googleapis/python-crc32c) | `==1.3.0` -> `==1.5.0` | [![age](https://badges.renovateapi.com/packages/pypi/google-crc32c/1.5.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/google-crc32c/1.5.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/google-crc32c/1.5.0/compatibility-slim/1.3.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/google-crc32c/1.5.0/confidence-slim/1.3.0)](https://docs.renovatebot.com/merge-confidence/) |

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-iam).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMDguMiIsInVwZGF0ZWRJblZlciI6IjMyLjIwOC4yIn0=-->
suztomo pushed a commit that referenced this issue Dec 16, 2022
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [io.grpc:grpc-protobuf](https://togithub.com/grpc/grpc-java) | `1.49.1` -> `1.49.2` | [![age](https://badges.renovateapi.com/packages/maven/io.grpc:grpc-protobuf/1.49.2/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/io.grpc:grpc-protobuf/1.49.2/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/io.grpc:grpc-protobuf/1.49.2/compatibility-slim/1.49.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/io.grpc:grpc-protobuf/1.49.2/confidence-slim/1.49.1)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>grpc/grpc-java</summary>

### [`v1.49.2`](https://togithub.com/grpc/grpc-java/compare/v1.49.1...v1.49.2)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-common-protos).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMDguMiIsInVwZGF0ZWRJblZlciI6IjMyLjIwOC4yIn0=-->
suztomo pushed a commit that referenced this issue Dec 16, 2022
🤖 I have created a release *beep* *boop*
---


## [1.6.2](https://togithub.com/googleapis/java-iam/compare/v1.6.1...v1.6.2) (2022-10-02)


### Documentation

* **samples:** Update package names to match v2 ([#424](https://togithub.com/googleapis/java-iam/issues/424)) ([3a4392a](https://togithub.com/googleapis/java-iam/commit/3a4392af5d222d349b2fb8352c041b7889be97b5))


### Dependencies

* Update dependency cachetools to v5 ([#459](https://togithub.com/googleapis/java-iam/issues/459)) ([89ea28b](https://togithub.com/googleapis/java-iam/commit/89ea28b2d57b4bdb11b8d847af313c63c8023146))
* Update dependency certifi to v2022.9.24 ([#440](https://togithub.com/googleapis/java-iam/issues/440)) ([de6c438](https://togithub.com/googleapis/java-iam/commit/de6c438b7709e71bdcc2c1c47702b808f828a42f))
* Update dependency charset-normalizer to v2.1.1 ([#444](https://togithub.com/googleapis/java-iam/issues/444)) ([5715206](https://togithub.com/googleapis/java-iam/commit/57152061f264629aa0f09f2602abf6fe3b242945))
* Update dependency click to v8.1.3 ([#445](https://togithub.com/googleapis/java-iam/issues/445)) ([189a5c4](https://togithub.com/googleapis/java-iam/commit/189a5c4102bd6b9f4fbfc252a67019a7c5e23ee3))
* Update dependency com.google.apis:google-api-services-cloudresourcemanager to v3-rev20220911-2.0.0 ([#435](https://togithub.com/googleapis/java-iam/issues/435)) ([5d415a9](https://togithub.com/googleapis/java-iam/commit/5d415a98f4e7cede137b57e048ec70c21ea8376d))
* Update dependency com.google.apis:google-api-services-cloudresourcemanager to v3-rev20220925-2.0.0 ([#439](https://togithub.com/googleapis/java-iam/issues/439)) ([b17765b](https://togithub.com/googleapis/java-iam/commit/b17765b5e897bcef60aeef56ed2524b418f73b65))
* Update dependency com.google.cloud:google-iam-policy to v1.6.1 ([#434](https://togithub.com/googleapis/java-iam/issues/434)) ([18d4bc0](https://togithub.com/googleapis/java-iam/commit/18d4bc0cd7341123d00eeb5fa15606d058f12fa6))
* Update dependency com.google.protobuf:protobuf-java to v3.21.7 ([#463](https://togithub.com/googleapis/java-iam/issues/463)) ([8ad215f](https://togithub.com/googleapis/java-iam/commit/8ad215f4543f7ffcd891ed6e1b202fe1ddccd86f))
* Update dependency gcp-releasetool to v1.8.8 ([#441](https://togithub.com/googleapis/java-iam/issues/441)) ([31fec95](https://togithub.com/googleapis/java-iam/commit/31fec95f348f55c98dab665bec47d88f396a9611))
* Update dependency google-api-core to v2.10.1 ([#446](https://togithub.com/googleapis/java-iam/issues/446)) ([50d8221](https://togithub.com/googleapis/java-iam/commit/50d82218cb3056bb49173d7f5d4e7b0070717b0f))
* Update dependency google-auth to v2.12.0 ([#447](https://togithub.com/googleapis/java-iam/issues/447)) ([97b4c23](https://togithub.com/googleapis/java-iam/commit/97b4c236276d27be1e290334573ec6897c9e67c9))
* Update dependency google-cloud-core to v2.3.2 ([#442](https://togithub.com/googleapis/java-iam/issues/442)) ([00adc9a](https://togithub.com/googleapis/java-iam/commit/00adc9a8bf225a4c3d1509f9e6778ad10dd16e2e))
* Update dependency google-cloud-storage to v2.5.0 ([#448](https://togithub.com/googleapis/java-iam/issues/448)) ([df5cf74](https://togithub.com/googleapis/java-iam/commit/df5cf74ee883b7f4d99ce9654fcdd6a4670cc98a))
* Update dependency google-crc32c to v1.5.0 ([#449](https://togithub.com/googleapis/java-iam/issues/449)) ([a2f7304](https://togithub.com/googleapis/java-iam/commit/a2f7304a602b4621f43d4b3966586e0a7e1a7a2d))
* Update dependency googleapis-common-protos to v1.56.4 ([#443](https://togithub.com/googleapis/java-iam/issues/443)) ([c64de5a](https://togithub.com/googleapis/java-iam/commit/c64de5a5b2f3fcd9e17ed4963e586aaf0a1209ba))
* Update dependency importlib-metadata to v4.12.0 ([#450](https://togithub.com/googleapis/java-iam/issues/450)) ([e8607ce](https://togithub.com/googleapis/java-iam/commit/e8607ce4d1c6b202726b185560920c742e056a30))
* Update dependency io.grpc:grpc-protobuf to v1.49.2 ([#464](https://togithub.com/googleapis/java-iam/issues/464)) ([0d24035](https://togithub.com/googleapis/java-iam/commit/0d2403530080668411981679ec01801d5e756e03))
* Update dependency io.grpc:grpc-stub to v1.49.2 ([#465](https://togithub.com/googleapis/java-iam/issues/465)) ([2b67643](https://togithub.com/googleapis/java-iam/commit/2b67643239cf9cf617ddd3d15d176fbdb574d15e))
* Update dependency jeepney to v0.8.0 ([#451](https://togithub.com/googleapis/java-iam/issues/451)) ([56c8f86](https://togithub.com/googleapis/java-iam/commit/56c8f86e437f49636edd5673b4336def947de475))
* Update dependency jinja2 to v3.1.2 ([#452](https://togithub.com/googleapis/java-iam/issues/452)) ([0ebc062](https://togithub.com/googleapis/java-iam/commit/0ebc06212f4dc10f8724f35705d1db9ab148beac))
* Update dependency markupsafe to v2.1.1 ([#454](https://togithub.com/googleapis/java-iam/issues/454)) ([93bd5ec](https://togithub.com/googleapis/java-iam/commit/93bd5ec7183cf306e4956261321038b923861276))
* Update dependency protobuf to v3.20.2 ([#455](https://togithub.com/googleapis/java-iam/issues/455)) ([fb47671](https://togithub.com/googleapis/java-iam/commit/fb47671168b256e9b76ecc16e52cf0674cbefce7))
* Update dependency protobuf to v4 ([#460](https://togithub.com/googleapis/java-iam/issues/460)) ([cb9637c](https://togithub.com/googleapis/java-iam/commit/cb9637ce2ed8976deda7a146a3df738f6afd158c))
* Update dependency pyjwt to v2.5.0 ([#461](https://togithub.com/googleapis/java-iam/issues/461)) ([2d696a0](https://togithub.com/googleapis/java-iam/commit/2d696a04f036369b25a3dceb29f8f1b855136890))
* Update dependency requests to v2.28.1 ([#456](https://togithub.com/googleapis/java-iam/issues/456)) ([b023d05](https://togithub.com/googleapis/java-iam/commit/b023d05d096ae796573c488869682c45f1de57b2))
* Update dependency typing-extensions to v4.3.0 ([#457](https://togithub.com/googleapis/java-iam/issues/457)) ([53a369c](https://togithub.com/googleapis/java-iam/commit/53a369c5f157bcfb2752c6b6503d2f5e76c226b8))
* Update dependency zipp to v3.8.1 ([#458](https://togithub.com/googleapis/java-iam/issues/458)) ([39ea408](https://togithub.com/googleapis/java-iam/commit/39ea4087f4b72a57ee09d6f312d05f7607d89bfb))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
suztomo pushed a commit that referenced this issue Mar 21, 2023
…s to v2.2.2 (#449)

[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.api.grpc:proto-google-common-protos](https://togithub.com/googleapis/java-common-protos) | `2.1.0` -> `2.2.2` | [![age](https://badges.renovateapi.com/packages/maven/com.google.api.grpc:proto-google-common-protos/2.2.2/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.api.grpc:proto-google-common-protos/2.2.2/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.api.grpc:proto-google-common-protos/2.2.2/compatibility-slim/2.1.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.api.grpc:proto-google-common-protos/2.2.2/confidence-slim/2.1.0)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/java-common-protos</summary>

### [`v2.2.2`](https://togithub.com/googleapis/java-common-protos/blob/master/CHANGELOG.md#&#8203;222-httpswwwgithubcomgoogleapisjava-common-protoscomparev221v222-2021-05-19)

[Compare Source](https://togithub.com/googleapis/java-common-protos/compare/v2.2.1...v2.2.2)

</details>

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻️ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box.

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-core).
suztomo pushed a commit that referenced this issue Mar 21, 2023
🤖 I have created a release \*beep\* \*boop\*
---
## [1.95.0](https://www.github.com/googleapis/java-core/compare/v1.94.8...v1.95.0) (2021-06-03)


### Features

* add `gcf-owl-bot[bot]` to `ignoreAuthors` ([#453](https://www.github.com/googleapis/java-core/issues/453)) ([668b2c7](https://www.github.com/googleapis/java-core/commit/668b2c76ea53e9ccc2764ab36f398a9e497a1b96))


### Dependencies

* update dependency com.google.api-client:google-api-client-bom to v1.31.5 ([#446](https://www.github.com/googleapis/java-core/issues/446)) ([3bdbbd8](https://www.github.com/googleapis/java-core/commit/3bdbbd88564885f8242c195308c703530b7ab0f4))
* update dependency com.google.api:gax-bom to v1.64.0-sp.1 ([#443](https://www.github.com/googleapis/java-core/issues/443)) ([ba14b8e](https://www.github.com/googleapis/java-core/commit/ba14b8ee13c35441c3d623314622648fa36ea61b))
* update dependency com.google.api:gax-bom to v1.65.0 ([#464](https://www.github.com/googleapis/java-core/issues/464)) ([3207d44](https://www.github.com/googleapis/java-core/commit/3207d44dd46d4d8dd0f6a51a1d5c17752e5e68ce))
* update dependency com.google.api.grpc:proto-google-common-protos to v2.2.2 ([#449](https://www.github.com/googleapis/java-core/issues/449)) ([cb171d1](https://www.github.com/googleapis/java-core/commit/cb171d130fe96aca106a7a03b6ed544720e57c2c))
* update dependency com.google.api.grpc:proto-google-common-protos to v2.3.0 ([#458](https://www.github.com/googleapis/java-core/issues/458)) ([7eff2c6](https://www.github.com/googleapis/java-core/commit/7eff2c66c1b3c385ecfd77254c4245e6d5d76199))
* update dependency com.google.api.grpc:proto-google-common-protos to v2.3.1 ([#463](https://www.github.com/googleapis/java-core/issues/463)) ([9ee280b](https://www.github.com/googleapis/java-core/commit/9ee280bc46ee5bb9938d2e99a1bc87c43d3c8141))
* update dependency com.google.api.grpc:proto-google-common-protos to v2.3.2 ([#466](https://www.github.com/googleapis/java-core/issues/466)) ([2213b6a](https://www.github.com/googleapis/java-core/commit/2213b6abdd8b15d76fc842a9d96a1b763a28adbd))
* update dependency com.google.api.grpc:proto-google-iam-v1 to v1.0.14 ([#439](https://www.github.com/googleapis/java-core/issues/439)) ([0f37e3a](https://www.github.com/googleapis/java-core/commit/0f37e3a36f0ca227ee4dbaa089241c49225ba90f))
* update dependency com.google.auth:google-auth-library-bom to v0.26.0 ([#456](https://www.github.com/googleapis/java-core/issues/456)) ([f99e636](https://www.github.com/googleapis/java-core/commit/f99e636e209f0e0c4adca6ed28e8f5a4976128c2))
* update dependency com.google.code.gson:gson to v2.8.7 ([#461](https://www.github.com/googleapis/java-core/issues/461)) ([8bae9dc](https://www.github.com/googleapis/java-core/commit/8bae9dc71e7ea08ada9d7c83cc3bd079ec6d5478))
* update dependency com.google.errorprone:error_prone_annotations to v2.7.1 ([#451](https://www.github.com/googleapis/java-core/issues/451)) ([a6ca43c](https://www.github.com/googleapis/java-core/commit/a6ca43c124ce0ceed7c35aa3779c498f57b84255))
* update dependency com.google.protobuf:protobuf-bom to v3.17.0 ([#445](https://www.github.com/googleapis/java-core/issues/445)) ([4dfe429](https://www.github.com/googleapis/java-core/commit/4dfe429724136c36ac9c6da47da8d426d99e30df))
* update dependency com.google.protobuf:protobuf-bom to v3.17.1 ([#460](https://www.github.com/googleapis/java-core/issues/460)) ([efb3811](https://www.github.com/googleapis/java-core/commit/efb3811c28d3fbebade15d2e7571cea9d4e1169e))
* update dependency com.google.protobuf:protobuf-bom to v3.17.2 ([#465](https://www.github.com/googleapis/java-core/issues/465)) ([54f6b28](https://www.github.com/googleapis/java-core/commit/54f6b28e083d2d39cb7c707138e2a7b0282f40a7))
* update dependency io.grpc:grpc-bom to v1.38.0 ([#450](https://www.github.com/googleapis/java-core/issues/450)) ([f401756](https://www.github.com/googleapis/java-core/commit/f4017565373742f34a8573b09a9de23ed4860a6a))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants