Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ggj] Refactor ThrowExpr to use NewObjectValue and StringObjectValue #809

Open
miraleung opened this issue Aug 2, 2021 · 3 comments
Open

[ggj] Refactor ThrowExpr to use NewObjectValue and StringObjectValue #809

miraleung opened this issue Aug 2, 2021 · 3 comments
Labels
priority: p4 type: cleanup An internal cleanup or hygiene concern.

Comments

@miraleung
Copy link
Contributor

No description provided.

@miraleung miraleung added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Aug 2, 2021
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels Nov 3, 2021
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Jan 29, 2022
@suztomo
Copy link
Member

suztomo commented Mar 15, 2022

@miraleung (I'm on the rotation this week) Do you think this issue is still valid? If so, would you provide more information in the issue description? I see it's empty now.

@meltsufin meltsufin added priority: p3 Desirable enhancement or fix. May not be included in next release. and removed priority: p2 Moderately-important priority. Fix may not be included in next release. labels Mar 16, 2022
@yoshi-automation yoshi-automation removed the 🚨 This issue needs some love. label Mar 16, 2022
@meltsufin meltsufin added priority: p4 and removed priority: p3 Desirable enhancement or fix. May not be included in next release. labels Dec 4, 2022
@meltsufin
Copy link
Member

@blakeli0 Does this issue make sense to you? Is it really a bug?

@blakeli0 blakeli0 added type: cleanup An internal cleanup or hygiene concern. and removed type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Dec 5, 2022
@blakeli0
Copy link
Collaborator

blakeli0 commented Dec 5, 2022

I think it makes sense to use refactor ThrowExpr to use NewObjectValue, as throwing an exception is basically an extension of creating a new object, not sure about the StringObjectValue part. I don't think it's a bug though, changed it to a cleanup

suztomo pushed a commit that referenced this issue Mar 21, 2023
@gcf-owl-bot
chore: pin versions of dependencies for compatibility with Python 3.6 (…
cb873f0 
…#1588) (#809)

* chore: pin versions of dependencies for compatibility with Python 3.6

* fix path of requirements file in synthtool
Source-Link: googleapis/synthtool@69cdb47
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:6566dc8226f20993af18e5a4e7a2b1ba85a292b02dedb6a1634cf10e1b418fa5
suztomo pushed a commit that referenced this issue Mar 21, 2023
@release-please
chore(main): release 2.7.0 (#809)
e453afe 
🤖 I have created a release *beep* *boop*
---


## [2.7.0](googleapis/java-core@v2.6.1...v2.7.0) (2022-05-18)


### Features

* **java:** remove native-image-support module ([#820](googleapis/java-core#820)) ([b827e0a](googleapis/java-core@b827e0a))
* next release from main branch is 2.7.0 ([#807](googleapis/java-core#807)) ([2145212](googleapis/java-core@2145212))


### Bug Fixes

* remove native-image-support module from version.txt ([#822](googleapis/java-core#822)) ([8285eee](googleapis/java-core@8285eee))


### Dependencies

* update dependency com.google.api-client:google-api-client-bom to v1.34.1 ([#823](googleapis/java-core#823)) ([58aac09](googleapis/java-core@58aac09))
* update dependency com.google.api:api-common to v2.2.0 ([#827](googleapis/java-core#827)) ([fa4a5db](googleapis/java-core@fa4a5db))
* update dependency com.google.api:gax-bom to v2.17.0 ([#826](googleapis/java-core#826)) ([d1d886d](googleapis/java-core@d1d886d))
* update dependency com.google.api:gax-bom to v2.18.0 ([#829](googleapis/java-core#829)) ([355dd4a](googleapis/java-core@355dd4a))
* update dependency com.google.api.grpc:proto-google-iam-v1 to v1.3.2 ([#805](googleapis/java-core#805)) ([c5b4893](googleapis/java-core@c5b4893))
* update dependency com.google.api.grpc:proto-google-iam-v1 to v1.3.3 ([#814](googleapis/java-core#814)) ([9621659](googleapis/java-core@9621659))
* update dependency com.google.api.grpc:proto-google-iam-v1 to v1.3.4 ([#825](googleapis/java-core#825)) ([8f907db](googleapis/java-core@8f907db))
* update dependency com.google.auth:google-auth-library-bom to v1.7.0 ([#828](googleapis/java-core#828)) ([0e53f0c](googleapis/java-core@0e53f0c))
* update dependency com.google.cloud:native-image-support to v0.14.0 ([#824](googleapis/java-core#824)) ([bbeb567](googleapis/java-core@bbeb567))
* update dependency com.google.errorprone:error_prone_annotations to v2.13.1 ([#806](googleapis/java-core#806)) ([c4d3e17](googleapis/java-core@c4d3e17))
* update dependency com.google.http-client:google-http-client-bom to v1.41.8 ([#821](googleapis/java-core#821)) ([8c747e1](googleapis/java-core@8c747e1))
* update dependency com.google.protobuf:protobuf-bom to v3.20.1 ([#813](googleapis/java-core#813)) ([f259b41](googleapis/java-core@f259b41))
* update dependency io.grpc:grpc-bom to v1.46.0 ([#815](googleapis/java-core#815)) ([2dc7507](googleapis/java-core@2dc7507))
* update opencensus.version to v0.31.1 ([#819](googleapis/java-core#819)) ([96982b0](googleapis/java-core@96982b0))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p4 type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@suztomo @blakeli0 @miraleung @meltsufin @yoshi-automation