[ggj] Add .circleci/config.yml #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vam-google
added a commit
to vam-google/gapic-generator-java
that referenced
this pull request
Apr 22, 2021
This is as minimal of a PR that I could make stuch that: 1) It compiles and tests run single composer plus minimal 2) All the key changes are present (abstract/grpc class, comment composer, class names, golden files move) I had to add a few quite ugly and artificial constructs: fake `ClassComposer` under `composer` package which simply extends `composer.common.Composer` to void changing the rest of the classes put back static methods in `ClassNames` and `StubCommentComposer` and `TestProtoLoaderUtil` (for the same reasons as above). All of those chagnes are marked with `// TODO: remove after Pre-DIREGAPIC refactoring is fully merged` statement.
vam-google
added a commit
that referenced
this pull request
May 18, 2021
* chore: Pre-DIREGAPIC Refactoring #1 This is as minimal of a PR that I could make stuch that: 1) It compiles and tests run single composer plus minimal 2) All the key changes are present (abstract/grpc class, comment composer, class names, golden files move) I had to add a few quite ugly and artificial constructs: fake `ClassComposer` under `composer` package which simply extends `composer.common.Composer` to void changing the rest of the classes put back static methods in `ClassNames` and `StubCommentComposer` and `TestProtoLoaderUtil` (for the same reasons as above). All of those chagnes are marked with `// TODO: remove after Pre-DIREGAPIC refactoring is fully merged` statement.
|
Kudos, SonarCloud Quality Gate passed!
|
suztomo
pushed a commit
that referenced
this pull request
Mar 21, 2023
🤖 I have created a release \*beep\* \*boop\* --- ## 0.1.0 (2020-03-30) ### Features * initial generation ([9f6eb94](https://www.github.com/googleapis/java-shared-dependencies/commit/9f6eb949f579ad25c63b47b95551375005930ca1)) ### Dependencies * update dependency com.google.api:api-common to v1.9.0 ([#3](https://www.github.com/googleapis/java-shared-dependencies/issues/3)) ([a0b3721](https://www.github.com/googleapis/java-shared-dependencies/commit/a0b3721afd62ff79cf7685ab7b608d145c5ab5da)) * update dependency org.threeten:threetenbp to v1.4.2 ([#4](https://www.github.com/googleapis/java-shared-dependencies/issues/4)) ([8264473](https://www.github.com/googleapis/java-shared-dependencies/commit/826447349fc7fef642c6a2bfcc0d10bc79acc89c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
4 tasks
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.