Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bazel): do not print current working directory #1028

Merged
merged 1 commit into from
Aug 19, 2022
Merged

fix(bazel): do not print current working directory #1028

merged 1 commit into from
Aug 19, 2022

Conversation

alexander-fenster
Copy link
Contributor

Each use of cd - prints the directory it's returning to. Let's not print it to save some log lines.

INFO: From Action google/cloud/commerce/consumer/procurement/v1alpha1/google-cloud-consumer-procurement-v1alpha1-java.tar.gz:
/bazel_root/1d081bf08a15278ca34ce779797e8450/sandbox/processwrapper-sandbox/15758/execroot/com_google_googleapis
INFO: From Action google/cloud/videointelligence/v1/gapi-cloud-videointelligence-v1-go.tar.gz:
/bazel_root/1d081bf08a15278ca34ce779797e8450/sandbox/processwrapper-sandbox/25287/execroot/com_google_googleapis

@alexander-fenster alexander-fenster requested review from a team as code owners August 19, 2022 04:58
@sonarcloud
Copy link

sonarcloud bot commented Aug 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

blakeli0
blakeli0 approved these changes Aug 19, 2022
View reviewed changes
Copy link
Collaborator

@blakeli0 blakeli0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Alex! LGTM

@alexander-fenster alexander-fenster merged commit 5d94f1d into main Aug 19, 2022
@alexander-fenster alexander-fenster deleted the cd-minus-to-dev-null branch August 19, 2022 17:39
@release-please release-please bot mentioned this pull request Aug 19, 2022
Merged
suztomo pushed a commit that referenced this pull request Dec 16, 2022
@alexander-fenster
fix(bazel): do not print current working directory (#1028)
a8356fa
suztomo pushed a commit that referenced this pull request Mar 21, 2023
@renovate-bot
deps: update dependency com.google.api.grpc:proto-google-iam-v1 to v1…
4feade4 
….6.10 (#1028)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakeli0 blakeli0 blakeli0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexander-fenster @blakeli0