fix(Spring CodeGen): switch to Spring boot 2.7 style in registering auto-configurations #1044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhumin8
changed the title
11 tasks
zhumin8
added
the
spring
emmileaf
approved these changes
Sep 29, 2022
| @@ -139,13 +139,14 @@ private static void writeMetadataFile(GapicContext context, String path, JarOutp | |||
| } | |||
|
|
|||
| private static void writeSpringFactories(GapicContext context, JarOutputStream jos) { | |||
There was a problem hiding this comment.
Would this mean we need to rebrand this method and the exception message as well? (To something like writeAutoConfigRegistration)
|
Kudos, SonarCloud Quality Gate passed! |
diegomarquezp
pushed a commit
that referenced
this pull request
Oct 22, 2022
…uto-configurations (#1044) Spring Boot 2.7 has introduced [changes to how auto-configurations](https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-2.7-Release-Notes#changes-to-auto-configuration) are registered. Both changes are backward compatible, but the older `spring.factories` style [will be removed in Spring Boot 3.0](https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-3.0.0-M5-Release-Notes#auto-configuration-registration). Also consider that Spring Boot 2.6.x goes out of support by 11-24-2022, switching this code to 2.7's new style.
suztomo
pushed a commit
that referenced
this pull request
Mar 21, 2023
chore: upgrade native image checks to graalvm-22.3.0 Source-Link: googleapis/synthtool@5e52896 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:27b1b1884dce60460d7521b23c2a73376cba90c0ef3d9f0d32e4bdb786959cfd Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spring Boot 2.7 has introduced changes to how auto-configurations are registered. Both changes are backward compatible, but the older
spring.factoriesstyle will be removed in Spring Boot 3.0.Also consider that Spring Boot 2.6.x goes out of support by 11-24-2022, switching this code to 2.7's new style.