fix(spring): add javadoc comments for configurable properties #1106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
emmileaf
added
the
spring
|
Rebasing on top of #1143, since previous approach for retry properties comments is no longer applicable |
emmileaf
force-pushed
the
spring-properties-javadoc
branch
from
4e803eb to
6d6d01e
Compare
emmileaf
changed the base branch from
autoconfig-gen-draft2
to
spring-refactor-retry-properties-2
emmileaf
changed the base branch from
spring-refactor-retry-properties-2
to
autoconfig-gen-draft2
emmileaf
changed the base branch from
autoconfig-gen-draft2
to
spring-refactor-retry-properties-2
|
Kudos, SonarCloud Quality Gate passed! |
Base automatically changed from
spring-refactor-retry-properties-2
to
autoconfig-gen-draft2
December 20, 2022 21:55
|
Managed to get this PR stuck in rebasing mess...closing and trying again in #1171. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is superseded by #1171.
This PR is a follow-up on GoogleCloudPlatform/spring-cloud-gcp#1364 (comment), and adds Javadoc comments to configurable properties.