Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: Update showcase version to 0.28.1 #1673

Merged
merged 3 commits into from
May 10, 2023
Merged

deps: Update showcase version to 0.28.1 #1673

merged 3 commits into from
May 10, 2023

Conversation

blakeli0
Copy link
Collaborator

No description provided.

@blakeli0 blakeli0 requested a review from a team as a code owner May 10, 2023 17:25
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label May 10, 2023
@snippet-bot
Copy link

snippet-bot bot commented May 10, 2023

Here is the summary of changes.

You are about to add 8 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: s Pull request size is small. labels May 10, 2023
@blakeli0 blakeli0 changed the title deps: Update showcase version to 0.28.0 deps: Update showcase version to 0.28.1 May 10, 2023
@sonarcloud
Copy link

sonarcloud bot commented May 10, 2023

[gapic-generator-java-root] SonarCloud Quality Gate failed.    Quality Gate failed

Bug B 7 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 156 Code Smells

5.7% 5.7% Coverage
43.1% 43.1% Duplication

@sonarcloud
Copy link

sonarcloud bot commented May 10, 2023

[java_showcase_integration_tests] SonarCloud Quality Gate failed.    Quality Gate failed

Bug B 7 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 148 Code Smells

0.0% 0.0% Coverage
42.9% 42.9% Duplication

@sonarcloud
Copy link

sonarcloud bot commented May 10, 2023

[java_showcase_unit_tests] SonarCloud Quality Gate failed.    Quality Gate failed

Bug B 7 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 148 Code Smells

5.7% 5.7% Coverage
42.9% 42.9% Duplication

blakeli0
blakeli0 commented May 10, 2023
View reviewed changes
WORKSPACE
_showcase_commit = "656e5f46d125a69c82c0cb7edcfcd8b03ed77b89"

_showcase_sha256 = "26d4b71ac31cbca5e4ed4cdcb5bfeca185e405392d70d2020b4528b5b47c8022"
_showcase_version = "0.28.1"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@burkedavison @mpeddada1 I'm changing this to use showcase version instead of committish as I think this is more intuitive, let me know if you have any concerns.

@blakeli0 blakeli0 merged commit 9a120e9 into main May 10, 2023
@blakeli0 blakeli0 deleted the update_showcase branch May 10, 2023 21:46
@release-please release-please bot mentioned this pull request May 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lqiu96 lqiu96 lqiu96 approved these changes

Assignees
No one assigned
Labels
size: xl Pull request size is extra large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blakeli0 @lqiu96