Skip to content

fix: use correct path as input to owlbot-copy#2233

Closed
diegomarquezp wants to merge 2 commits intomainfrom
owlbot-copy-fix
Closed

fix: use correct path as input to owlbot-copy#2233
diegomarquezp wants to merge 2 commits intomainfrom
owlbot-copy-fix

Conversation

@diegomarquezp
Copy link
Contributor

@diegomarquezp diegomarquezp commented Nov 9, 2023

Currently, the library generation integration test for google/iam/v1 succeeds although no java files were transferred to the final folder. A check was added in the IT to prevent this situation from passing.

This fix is intended to adapt to .OwlBot.yaml files that specify the full path in googleapis-gen to the desired source library. The tradeoff is an extra argument to generate_library.sh

This example does not use wildcards:

deep-copy-regex:
  - source: "/google/iam/v2beta/google-cloud-iam-v2beta-java/gapic-google-cloud-iam-v2beta-java/src"
    dest: "/owl-bot-staging/java-iam/v2beta/google-iam-policy/src"
  - source: "/google/iam/v2/google-cloud-iam-v2-java/gapic-google-cloud-iam-v2-java/src"
    dest: "/owl-bot-staging/java-iam/v2/google-iam-policy/src"

Our current logic uses a generated-java folder that will not produce a match for owlbot copy using the yaml above.
This logic assumed all .OwlBot.yaml files looked like this one

deep-copy-regex:
- source: "/google/cloud/alloydb/(v.*)/.*-java/proto-google-.*/src"
  dest: "/owl-bot-staging/java-alloydb/$1/proto-google-cloud-alloydb-$1/src"

@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Nov 9, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 9, 2023

[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 9, 2023

[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@blakeli0
Copy link
Contributor

blakeli0 commented Nov 9, 2023

This fix is intended to adapt to .OwlBot.yaml files that specify the full path in googleapis-gen to the desired source library. The tradeoff is an extra argument to generate_library.sh

I would rather us fixing the non-standard owlbot configuration rather than accommodating it in our scripts, especially at the cost of one more parameter. Is there any harm in fixing the owlbot config for iam?

@diegomarquezp
Copy link
Contributor Author

This fix is intended to adapt to .OwlBot.yaml files that specify the full path in googleapis-gen to the desired source library. The tradeoff is an extra argument to generate_library.sh

I would rather us fixing the non-standard owlbot configuration rather than accommodating it in our scripts, especially at the cost of one more parameter. Is there any harm in fixing the owlbot config for iam?

@blakeli0 Sounds good. I created googleapis/google-cloud-java#10050 to address this.

@diegomarquezp
Copy link
Contributor Author

This approach is obsolete. googleapis/google-cloud-java#10050 fixed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants