fix: use correct path as input to owlbot-copy#2233
fix: use correct path as input to owlbot-copy#2233diegomarquezp wants to merge 2 commits intomainfrom
Conversation
|
[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed! |
|
[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed! |
I would rather us fixing the non-standard owlbot configuration rather than accommodating it in our scripts, especially at the cost of one more parameter. Is there any harm in fixing the owlbot config for iam? |
@blakeli0 Sounds good. I created googleapis/google-cloud-java#10050 to address this. |
|
This approach is obsolete. googleapis/google-cloud-java#10050 fixed this |








Currently, the library generation integration test for
google/iam/v1succeeds although no java files were transferred to the final folder. A check was added in the IT to prevent this situation from passing.This fix is intended to adapt to
.OwlBot.yamlfiles that specify the full path in googleapis-gen to the desired source library. The tradeoff is an extra argument togenerate_library.shThis example does not use wildcards:
Our current logic uses a
generated-javafolder that will not produce a match for owlbot copy using the yaml above.This logic assumed all
.OwlBot.yamlfiles looked like this one