Skip to content

Revert "deps: update dependency com.googlecode.maven-download-plugin:download-maven-plugin to v1.7.1"#2271

Merged
mpeddada1 merged 17 commits intomainfrom
revert-2151-renovate/com.googlecode.maven-download-plugin-download-maven-plugin-1.x
Nov 29, 2023
Merged

Revert "deps: update dependency com.googlecode.maven-download-plugin:download-maven-plugin to v1.7.1"#2271
mpeddada1 merged 17 commits intomainfrom
revert-2151-renovate/com.googlecode.maven-download-plugin-download-maven-plugin-1.x

Conversation

@mpeddada1
Copy link
Contributor

Reverts #2151. Version 1.7.0 introduced a change that broke backward compatibility (download-maven-plugin/download-maven-plugin#246), however failure with caching still exists in 1.7.1 unless we add the skipCache option. Similar failures were also seen in #2228. Holding off on updating this dependency to investigate further.

…download-maven-plugin to v1.7.1 (#2151)"

This reverts commit cbe1bb1.
@mpeddada1 mpeddada1 requested a review from a team November 29, 2023 16:07
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Nov 29, 2023
@mpeddada1 mpeddada1 closed this Nov 29, 2023
@mpeddada1 mpeddada1 reopened this Nov 29, 2023
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Nov 29, 2023
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Nov 29, 2023
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: m Pull request size is medium. labels Nov 29, 2023
@product-auto-label product-auto-label bot removed the size: s Pull request size is small. label Nov 29, 2023
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Nov 29, 2023
@sonarqubecloud
Copy link

[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mpeddada1
Copy link
Contributor Author

mpeddada1 commented Nov 29, 2023

@lqiu96 discovered that the CI logs were still using version 1.7.1 of the download-maven-plugin despite being downgraded in this PR. The logs of the Install sdk-platform-java and showcase to local maven repository GA step show:

[INFO] --- download-maven-plugin:1.7.1:wget (download-common-resources-proto) @ gapic-generator-java ---
[INFO] 
[INFO] --- download-maven-plugin:1.7.1:wget (download-pubsub-proto) @ gapic-generator-java ---
[INFO] 

This line references the main branch which prevents the changes in this PR from taking effect.

Commented out this line and cleaning up debug logic results in a successful build.

Since the clirr check needs to run against the main branch, we will merge this PR in with the failing the showcase-clirr check check the downgrade change into main and rebase the failing release PR.

@sonarqubecloud
Copy link

[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mpeddada1 mpeddada1 merged commit 7beaccf into main Nov 29, 2023
@mpeddada1 mpeddada1 deleted the revert-2151-renovate/com.googlecode.maven-download-plugin-download-maven-plugin-1.x branch November 29, 2023 21:16
lqiu96 pushed a commit that referenced this pull request Dec 6, 2023
…download-maven-plugin to v1.7.1" (#2271)

* Revert "deps: update dependency com.googlecode.maven-download-plugin:download-maven-plugin to v1.7.1 (#2151)"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants