Conversation
lqiu96
approved these changes
Nov 29, 2023
…in-download-maven-plugin-1.x' of github.com:googleapis/sdk-platform-java into revert-2151-renovate/com.googlecode.maven-download-plugin-download-maven-plugin-1.x
|
[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed! |
Contributor
Author
|
@lqiu96 discovered that the CI logs were still using version This line references the main branch which prevents the changes in this PR from taking effect. Commented out this line and cleaning up debug logic results in a successful build. Since the clirr check needs to run against the |
|
[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Reverts #2151. Version
1.7.0introduced a change that broke backward compatibility (download-maven-plugin/download-maven-plugin#246), however failure with caching still exists in 1.7.1 unless we add theskipCacheoption. Similar failures were also seen in #2228. Holding off on updating this dependency to investigate further.