Skip to content

build: do not declare javadoc plugin version#2272

Merged
alicejli merged 1 commit intomainfrom
removeMavenPluginDeclaration
Nov 29, 2023
Merged

build: do not declare javadoc plugin version#2272
alicejli merged 1 commit intomainfrom
removeMavenPluginDeclaration

Conversation

@alicejli
Copy link
Contributor

@alicejli alicejli requested a review from a team November 29, 2023 16:10
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Nov 29, 2023
@sonarqubecloud
Copy link

[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@alicejli
Copy link
Contributor Author

Pretty sure the showcase-clirr check failure is unrelated:

Error:  PROTOC FAILED: gapic_metadata.proto:1:1: Invalid control characters encountered in text.

as it is mentioned in: #2270

@alicejli alicejli merged commit c0cf19e into main Nov 29, 2023
@alicejli alicejli deleted the removeMavenPluginDeclaration branch November 29, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants