chore: add google/shopping/type/types.proto when generating shopping APIs
#2414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blakeli0
reviewed
Jan 24, 2024
| # this proto is included in //google/shopping/css/v1:google-cloud-shopping-css-v1-java | ||
| # and //google/shopping/merchant/inventories/v1beta:google-cloud-merchant-inventories-v1beta-java | ||
| # and //google/shopping/merchant/reports/v1beta:google-cloud-merchant-reports-v1beta-java | ||
| proto_files="${proto_files} google/shopping/type/types.proto" |
There was a problem hiding this comment.
Do we still need to include them here if these are included in java-common-protos?
There was a problem hiding this comment.
Some classes are missing in proto-* directory if google/shopping/type/types.proto is excluded.
deleted: java-shopping-css/proto-google-shopping-css-v1/src/main/java/com/google/shopping/type/Channel.java
deleted: java-shopping-css/proto-google-shopping-css-v1/src/main/java/com/google/shopping/type/ChannelOrBuilder.java
deleted: java-shopping-css/proto-google-shopping-css-v1/src/main/java/com/google/shopping/type/CustomAttribute.java
deleted: java-shopping-css/proto-google-shopping-css-v1/src/main/java/com/google/shopping/type/CustomAttributeOrBuilder.java
deleted: java-shopping-css/proto-google-shopping-css-v1/src/main/java/com/google/shopping/type/Destination.java
deleted: java-shopping-css/proto-google-shopping-css-v1/src/main/java/com/google/shopping/type/DestinationOrBuilder.java
deleted: java-shopping-css/proto-google-shopping-css-v1/src/main/java/com/google/shopping/type/Price.java
deleted: java-shopping-css/proto-google-shopping-css-v1/src/main/java/com/google/shopping/type/PriceOrBuilder.java
deleted: java-shopping-css/proto-google-shopping-css-v1/src/main/java/com/google/shopping/type/ReportingContext.java
deleted: java-shopping-css/proto-google-shopping-css-v1/src/main/java/com/google/shopping/type/ReportingContextOrBuilder.java
deleted: java-shopping-css/proto-google-shopping-css-v1/src/main/java/com/google/shopping/type/TypesProto.java
So I think the answer to your question is no (these classes can be inherited from shared dependencies).
diegomarquezp
approved these changes
Jan 24, 2024
|
Hold this PR until #2018 is resolved. |
blakeli0
approved these changes
Jan 24, 2024
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
google/shopping/type/types.protowhen generating from google/shopping.We decided to add an edge case in
generate_library.shas a temporary fix. The long-term solution will be adding an org-level common protos in sdk-platform-java.