fix: exclude path_to_yaml when compares configs #2633
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
blakeli0
reviewed
Apr 12, 2024
| @@ -38,10 +38,12 @@ def compare_config( | |||
| :return: a ConfigChange objects. | |||
| """ | |||
| diff = defaultdict(list[LibraryChange]) | |||
| # these params are not used in config comparison. | |||
| excluded_params = {"path_to_yaml"} | |||
There was a problem hiding this comment.
Why do we need this parameter in GenerationConfig class? How is it used? I thought GenerationConfig is a pure representation for the yaml, but looks like it includes more things.
There was a problem hiding this comment.
This parameter is added in #2443.
Basically, this parameter is used to run template exclusion using our own implementation of synthtool.
|
We'll try to remove this parameter out of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
path_to_yamlwhen compares generation configs because this parameter is not used in library generation.