chore: Change all the references of OwlBot.yaml to OwlBot-hermetic.yaml. #2642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeWang1127
reviewed
Apr 15, 2024
|
|
JoeWang1127
approved these changes
Apr 16, 2024
diegomarquezp
approved these changes
Apr 16, 2024
| @@ -74,12 +75,12 @@ if [[ "${is_monorepo}" == "true" ]]; then | |||
| # - "/google-.*/src" | |||
|
|
|||
| library_name=$(basename "${postprocessing_target}") | |||
| cat "${postprocessing_target}/.OwlBot.yaml" \ | |||
| cat "${postprocessing_target}/${owlbot_yaml_file_name}" \ | |||
| | sed "s/- \"\/${library_name}/ - \"/" \ | |||
| > "${postprocessing_target}/.OwlBot.hermetic.yaml" | |||
There was a problem hiding this comment.
As a follow up, we may want to modify the regexes in every yaml of google-cloud-java:
/java-asset/google-.*/src
to
/google-.*/src
That way, we can get rid of this logic that creates a temporary owlbot yaml (which has a very similar name too)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is follow up of googleapis/google-cloud-java#10696. The hermetic build generation process would fail without this PR due to unable to find OwlBot.yaml files.
This PR changes all the references of
OwlBot.yamltoOwlBot-hermetic.yaml, removesOwlBot.yamlfrom a few places that don't need to reference it in the first places.