-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ggj][engx] fix: use singleton in MetacharEscaper #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Sep 3, 2020
xiaozhenliu-gg5
approved these changes
Sep 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! the build failure is from the name change charEscaper
instead of escaper
(original name). Thanks for fixing this.
suztomo
pushed a commit
that referenced
this pull request
Dec 16, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### [2.7.1](https://www.github.com/googleapis/java-common-protos/compare/v2.7.0...v2.7.1) (2022-01-05) ### Bug Fixes * **java:** add -ntp flag to native image testing command ([#1299](https://www.github.com/googleapis/java-common-protos/issues/1299)) ([#272](https://www.github.com/googleapis/java-common-protos/issues/272)) ([7f0784e](https://www.github.com/googleapis/java-common-protos/commit/7f0784eda9292fb8d7d89ccc10e65abfb0adeb24)) * **java:** run Maven in plain console-friendly mode ([#1301](https://www.github.com/googleapis/java-common-protos/issues/1301)) ([#283](https://www.github.com/googleapis/java-common-protos/issues/283)) ([e8581a4](https://www.github.com/googleapis/java-common-protos/commit/e8581a455a70e6b4fd666536efd85e290ad40370)) ### Dependencies * update dependency com.google.protobuf:protobuf-bom to v3.19.2 ([#285](https://www.github.com/googleapis/java-common-protos/issues/285)) ([6e4ee04](https://www.github.com/googleapis/java-common-protos/commit/6e4ee040712b6733bf46dfa1cb2115d7fd24c1b4)) * update dependency com.google.protobuf:protobuf-java to v3.19.2 ([#286](https://www.github.com/googleapis/java-common-protos/issues/286)) ([e2f7272](https://www.github.com/googleapis/java-common-protos/commit/e2f72726c6ffa88d8bec024d1e330e110469094c)) * update dependency io.grpc:grpc-bom to v1.43.1 ([#276](https://www.github.com/googleapis/java-common-protos/issues/276)) ([1d64bc1](https://www.github.com/googleapis/java-common-protos/commit/1d64bc12929fba276dea742d1b908377dfa4097d)) * update dependency io.grpc:grpc-protobuf to v1.43.1 ([#277](https://www.github.com/googleapis/java-common-protos/issues/277)) ([fe70634](https://www.github.com/googleapis/java-common-protos/commit/fe70634a4b7041eb2d6370f8a8e123006f605d5e)) * update dependency io.grpc:grpc-stub to v1.43.1 ([#278](https://www.github.com/googleapis/java-common-protos/issues/278)) ([9ffc759](https://www.github.com/googleapis/java-common-protos/commit/9ffc759dab14601b9271d9c04525d67cb51c4901)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
suztomo
pushed a commit
that referenced
this pull request
Dec 16, 2022
…cies to v2.7.0 (#273) [![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-shared-dependencies](https://togithub.com/googleapis/java-shared-dependencies) | `2.6.0` -> `2.7.0` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-dependencies/2.7.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-dependencies/2.7.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-dependencies/2.7.0/compatibility-slim/2.6.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-dependencies/2.7.0/confidence-slim/2.6.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-shared-dependencies</summary> ### [`v2.7.0`](https://togithub.com/googleapis/java-shared-dependencies/blob/HEAD/CHANGELOG.md#​270-httpsgithubcomgoogleapisjava-shared-dependenciescomparev260v270-2022-01-28) [Compare Source](https://togithub.com/googleapis/java-shared-dependencies/compare/v2.6.0...v2.7.0) ##### Dependencies - update dependency com.fasterxml.jackson:jackson-bom to v2.13.1 ([#​555](https://togithub.com/googleapis/java-shared-dependencies/issues/555)) ([67b5663](https://togithub.com/googleapis/java-shared-dependencies/commit/67b56635509215fd132b2ffbcaed995a6de93879)) - update dependency com.google.api-client:google-api-client-bom to v1.33.1 ([#​580](https://togithub.com/googleapis/java-shared-dependencies/issues/580)) ([895dba2](https://togithub.com/googleapis/java-shared-dependencies/commit/895dba2afef6c295b0e21a4ccd27feee1b6af8e2)) - update dependency com.google.api:api-common to v2.1.3 ([#​587](https://togithub.com/googleapis/java-shared-dependencies/issues/587)) ([5dbbce8](https://togithub.com/googleapis/java-shared-dependencies/commit/5dbbce80baa045818757912e6db4f222c12b75f6)) - update dependency com.google.auth:google-auth-library-bom to v1.4.0 ([#​578](https://togithub.com/googleapis/java-shared-dependencies/issues/578)) ([c274c62](https://togithub.com/googleapis/java-shared-dependencies/commit/c274c62905192bcc48c82104bf50cbeaa1894c2b)) - update dependency com.google.errorprone:error_prone_annotations to v2.11.0 ([#​582](https://togithub.com/googleapis/java-shared-dependencies/issues/582)) ([314da38](https://togithub.com/googleapis/java-shared-dependencies/commit/314da38c9f12cf425b5d1be8297e9f2a78d13948)) - update dependency com.google.http-client:google-http-client-bom to v1.41.2 ([#​579](https://togithub.com/googleapis/java-shared-dependencies/issues/579)) ([c8df06d](https://togithub.com/googleapis/java-shared-dependencies/commit/c8df06ddb3f4a975e928bbdd9dfae293e81efa39)) - update dependency com.google.oauth-client:google-oauth-client-bom to v1.33.0 ([#​576](https://togithub.com/googleapis/java-shared-dependencies/issues/576)) ([3315988](https://togithub.com/googleapis/java-shared-dependencies/commit/3315988059ca0223f078b0f760960674bfa8c04a)) - update dependency com.google.protobuf:protobuf-bom to v3.19.3 ([#​571](https://togithub.com/googleapis/java-shared-dependencies/issues/571)) ([c1931e1](https://togithub.com/googleapis/java-shared-dependencies/commit/c1931e1c4611ca3d1e2afac1c9e983cf1ec4a7de)) - update dependency io.grpc:grpc-bom to v1.44.0 ([#​586](https://togithub.com/googleapis/java-shared-dependencies/issues/586)) ([52c47b7](https://togithub.com/googleapis/java-shared-dependencies/commit/52c47b7425af438ba1a82dac87f9002353a6a87a)) - update dependency org.checkerframework:checker-qual to v3.21.1 ([#​554](https://togithub.com/googleapis/java-shared-dependencies/issues/554)) ([81bbb91](https://togithub.com/googleapis/java-shared-dependencies/commit/81bbb91774ab67161371bfd0dfd143de89dee4c9)) - update gax.version to v2.11.0 ([#​581](https://togithub.com/googleapis/java-shared-dependencies/issues/581)) ([1899612](https://togithub.com/googleapis/java-shared-dependencies/commit/189961226f84cdd4e283780d2c7d4a4dffc3e00c)) - update gax.version to v2.9.0 ([#​573](https://togithub.com/googleapis/java-shared-dependencies/issues/573)) ([ee5e38e](https://togithub.com/googleapis/java-shared-dependencies/commit/ee5e38efea574eeb2b5803192da98ba1ce1c8e6e)) - update google.common-protos.version to v2.7.2 ([#​588](https://togithub.com/googleapis/java-shared-dependencies/issues/588)) ([caac0e6](https://togithub.com/googleapis/java-shared-dependencies/commit/caac0e68e336b801becb6322b5b81fce1824ad8a)) - update google.core.version to v2.4.0 ([#​589](https://togithub.com/googleapis/java-shared-dependencies/issues/589)) ([6a292e3](https://togithub.com/googleapis/java-shared-dependencies/commit/6a292e3530a06d6b228f3154ed4e979ef68d7aeb)) - update iam.version to v1.2.1 ([#​569](https://togithub.com/googleapis/java-shared-dependencies/issues/569)) ([62dd270](https://togithub.com/googleapis/java-shared-dependencies/commit/62dd2705b257c4bb539bfe619234f38d0e13b138)) - update opencensus.version to v0.30.0 ([#​552](https://togithub.com/googleapis/java-shared-dependencies/issues/552)) ([ebae62e](https://togithub.com/googleapis/java-shared-dependencies/commit/ebae62eca75234db4fd571f42b8ed0f6ce1bd1f7)) - update opencensus.version to v0.31.0 ([#​585](https://togithub.com/googleapis/java-shared-dependencies/issues/585)) ([021b066](https://togithub.com/googleapis/java-shared-dependencies/commit/021b066a833af1629c89fcca593d16b9786ee0bf)) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-iam).
suztomo
pushed a commit
that referenced
this pull request
Dec 16, 2022
🤖 I have created a release *beep* *boop* --- ### [1.2.2](googleapis/java-iam@v1.2.1...v1.2.2) (2022-02-03) ### Dependencies * **java:** update actions/github-script action to v5 ([#1339](https://github.com/googleapis/java-iam/issues/1339)) ([#267](googleapis/java-iam#267)) ([c2c9395](googleapis/java-iam@c2c9395)) * update dependency com.google.api:api-common to v2.1.3 ([#271](googleapis/java-iam#271)) ([ef30324](googleapis/java-iam@ef30324)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.7.0 ([#273](googleapis/java-iam#273)) ([43ce7e6](googleapis/java-iam@43ce7e6)) * update dependency com.google.protobuf:protobuf-java to v3.19.3 ([#262](googleapis/java-iam#262)) ([9a64030](googleapis/java-iam@9a64030)) * update dependency com.google.protobuf:protobuf-java to v3.19.4 ([#272](googleapis/java-iam#272)) ([f75ceb8](googleapis/java-iam@f75ceb8)) * update dependency io.grpc:grpc-protobuf to v1.44.0 ([#269](googleapis/java-iam#269)) ([334fe8e](googleapis/java-iam@334fe8e)) * update dependency io.grpc:grpc-stub to v1.44.0 ([#270](googleapis/java-iam#270)) ([acb1fb9](googleapis/java-iam@acb1fb9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
suztomo
pushed a commit
that referenced
this pull request
Mar 21, 2023
suztomo
pushed a commit
that referenced
this pull request
Mar 21, 2023
🤖 I have created a release \*beep\* \*boop\* --- ## [0.19.0](https://www.github.com/googleapis/java-shared-dependencies/compare/0.18.0...v0.19.0) (2021-02-19) ### Bug Fixes * update repo name ([#274](https://www.github.com/googleapis/java-shared-dependencies/issues/274)) ([ef4d41d](https://www.github.com/googleapis/java-shared-dependencies/commit/ef4d41d287a8f976423ef3458e6f37f0720e31d6)) ### Dependencies * downgrade opencensus version back to 0.28.0 ([#265](https://www.github.com/googleapis/java-shared-dependencies/issues/265)) ([ccc788c](https://www.github.com/googleapis/java-shared-dependencies/commit/ccc788c3333af43ebdba21c8917ddd8518c8e06e)) * update dependency com.google.api-client:google-api-client-bom to v1.31.2 ([#254](https://www.github.com/googleapis/java-shared-dependencies/issues/254)) ([071ffce](https://www.github.com/googleapis/java-shared-dependencies/commit/071ffce39e9c0b485eadb0eacf719c25fa59eb30)) * update dependency com.google.auth:google-auth-library-bom to v0.23.0 ([#261](https://www.github.com/googleapis/java-shared-dependencies/issues/261)) ([e94c82f](https://www.github.com/googleapis/java-shared-dependencies/commit/e94c82f8f16577f75a1f8fe8f73cef6b07c3ae6a)) * update dependency com.google.cloud:google-cloud-core to v1.94.1 ([#272](https://www.github.com/googleapis/java-shared-dependencies/issues/272)) ([b14eaab](https://www.github.com/googleapis/java-shared-dependencies/commit/b14eaab9ae0d5858fd996d679904a36de4deebe0)) * update dependency com.google.errorprone:error_prone_annotations to v2.5.1 ([#255](https://www.github.com/googleapis/java-shared-dependencies/issues/255)) ([7eae476](https://www.github.com/googleapis/java-shared-dependencies/commit/7eae4764ddd6a0a23754e0df7f8363a13e0c50a5)) * update dependency com.google.http-client:google-http-client-bom to v1.38.1 ([#253](https://www.github.com/googleapis/java-shared-dependencies/issues/253)) ([052b017](https://www.github.com/googleapis/java-shared-dependencies/commit/052b017fd7aa2b0c03972371e7f98d83e4a69dcd)) * update dependency com.google.protobuf:protobuf-bom to v3.15.0 ([#278](https://www.github.com/googleapis/java-shared-dependencies/issues/278)) ([3049848](https://www.github.com/googleapis/java-shared-dependencies/commit/30498489b65261024787029da596e51a877693b5)) * update dependency io.grpc:grpc-bom to v1.35.0 ([#248](https://www.github.com/googleapis/java-shared-dependencies/issues/248)) ([82a3ce8](https://www.github.com/googleapis/java-shared-dependencies/commit/82a3ce84a10615a2986a2badfcb742b1efeb2d36)) * update gax.version to v1.61.0 ([#277](https://www.github.com/googleapis/java-shared-dependencies/issues/277)) ([ee914fc](https://www.github.com/googleapis/java-shared-dependencies/commit/ee914fcada1c61acc98eb3723999ac1c8295fda3)) * update iam.version to v1.0.7 ([#252](https://www.github.com/googleapis/java-shared-dependencies/issues/252)) ([25cf7dd](https://www.github.com/googleapis/java-shared-dependencies/commit/25cf7dda681e967160ab2cdacda244e2d0db0768)) * update iam.version to v1.0.8 ([#273](https://www.github.com/googleapis/java-shared-dependencies/issues/273)) ([a0c677f](https://www.github.com/googleapis/java-shared-dependencies/commit/a0c677f843dc029996c0775b09146a5015ba667f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
suztomo
pushed a commit
that referenced
this pull request
Mar 21, 2023
suztomo
pushed a commit
that referenced
this pull request
Mar 21, 2023
🤖 I have created a release \*beep\* \*boop\* --- ### [1.93.9](https://www.github.com/googleapis/java-core/compare/v1.93.8...v1.93.9) (2020-09-23) ### Dependencies * update dependency com.google.api.grpc:proto-google-iam-v1 to v1.0.1 ([#282](https://www.github.com/googleapis/java-core/issues/282)) ([989c23c](https://www.github.com/googleapis/java-core/commit/989c23c9b7896e927412ebbe5add74001a430536)) * update dependency com.google.protobuf:protobuf-bom to v3.13.0 ([#273](https://www.github.com/googleapis/java-core/issues/273)) ([8366e21](https://www.github.com/googleapis/java-core/commit/8366e21bc602d616385d92a0d32d062c20b684a4)) * update dependency io.grpc:grpc-bom to v1.32.1 ([#270](https://www.github.com/googleapis/java-core/issues/270)) ([95af1e2](https://www.github.com/googleapis/java-core/commit/95af1e2d43cad98e56ce0ec81b3b02102db096c4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.