[ggj][infra][4/5]feat: move the expected string in unit test to golden files #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
xiaozhenliu-gg5
commented
Sep 8, 2020
src/test/java/com/google/api/generator/engine/JavaCodeGeneratorTest.java
Outdated
Show resolved
Hide resolved
xiaozhenliu-gg5
changed the title
xiaozhenliu-gg5
changed the title
xiaozhenliu-gg5
requested review from
miraleung and
summer-ji-eng
as code owners
xiaozhenliu-gg5
changed the title
miraleung
suggested changes
Sep 23, 2020
...ava/com/google/api/generator/gapic/composer/GrpcServiceCallableFactoryClassComposerTest.java
Outdated
Show resolved
Hide resolved
...ava/com/google/api/generator/gapic/composer/GrpcServiceCallableFactoryClassComposerTest.java
Outdated
Show resolved
Hide resolved
miraleung
suggested changes
Sep 23, 2020
...ava/com/google/api/generator/gapic/composer/GrpcServiceCallableFactoryClassComposerTest.java
Outdated
Show resolved
Hide resolved
xiaozhenliu-gg5
commented
Sep 24, 2020
| @@ -37,8 +37,9 @@ java_proto_library( | |||
|
|
|||
| [java_test( | |||
| name = test_name, | |||
| srcs = ["{0}.java".format(test_name)], | |||
| srcs = glob(["*.java"]), | |||
| data = [ | |||
There was a problem hiding this comment.
This change is for including ComposerConstants.java as src, not only the tests files.
There was a problem hiding this comment.
How about:
srcs = [
"{0}.java".format(test_name)",
"ComposerConstants.java",
]
There was a problem hiding this comment.
Thanks! That should also work, while if we add more helpers, those files have to be explicitly included. By using glob(["*.java"]) we can avoid modifying this even if more files are added. WDYT? @miraleung
There was a problem hiding this comment.
Done! Talked offline and for suggested option, we can avoid including other test files.
xiaozhenliu-gg5
commented
Sep 24, 2020
…nto add_golden_files
This was referenced Sep 24, 2020
miraleung
suggested changes
Sep 25, 2020
| @@ -37,8 +37,9 @@ java_proto_library( | |||
|
|
|||
| [java_test( | |||
| name = test_name, | |||
| srcs = ["{0}.java".format(test_name)], | |||
| srcs = glob(["*.java"]), | |||
| data = [ | |||
There was a problem hiding this comment.
How about:
srcs = [
"{0}.java".format(test_name)",
"ComposerConstants.java",
]
miraleung
approved these changes
Sep 29, 2020
suztomo
pushed a commit
that referenced
this pull request
Dec 16, 2022
…onfig to v1.2.7 (#279) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-shared-config](https://togithub.com/googleapis/java-shared-config) | `1.2.6` -> `1.2.7` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-shared-config</summary> ### [`v1.2.7`](https://togithub.com/googleapis/java-shared-config/blob/HEAD/CHANGELOG.md#​127-httpsgithubcomgoogleapisjava-shared-configcomparev126v127-2022-02-04) [Compare Source](https://togithub.com/googleapis/java-shared-config/compare/v1.2.6...v1.2.7) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-iam).
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Find more details in design doc: go/java-micro-file-diff-infra
Move the expected codegen string into goldens files, no logic for updating goldens is included.
update_golden bazel rules for each unit test will be coming once #314 merged in.