Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: add opentelemetry exporter-metrics and shared-resoucemapping to shared dependencies #3078

Merged
merged 4 commits into from
Sep 6, 2024
Merged

deps: add opentelemetry exporter-metrics and shared-resoucemapping to shared dependencies #3078

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
645848a
deps:add opentelemetry exporter-metrics and shared-resoucemapping to …
JesseLovelace Jul 31, 2024
6e8d94c
Merge branch 'main' into addotelexp
JesseLovelace Aug 27, 2024
5cae6d5
don't create unnecessary version
JesseLovelace Sep 5, 2024
715bca6
Merge branch 'main' into addotelexp
ldetmer Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions java-shared-dependencies/third-party-dependencies/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@
<perfmark-api.version>0.27.0</perfmark-api.version>
<j2objc-annotations.version>3.0.0</j2objc-annotations.version>
<google.cloud.opentelemetry.version>0.31.0</google.cloud.opentelemetry.version>
<opentelemetry-exporter-metrics.version>0.31.0</opentelemetry-exporter-metrics.version>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do they just happen to have the same version or they will always have the same version? The google.cloud.opentelemetry.version above also has the same value 0.31.0. If they will always be the same, we don't have to introduce new properties.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JesseLovelace bumping the above comment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

<opentelemetry-shared-resourcemapping.version>0.31.0</opentelemetry-shared-resourcemapping.version>
<opentelemetry-grpc-instrumentation.version>2.1.0-alpha</opentelemetry-grpc-instrumentation.version>
<opentelemetry-semconv.version>1.26.0-alpha</opentelemetry-semconv.version>
<flogger.version>0.8</flogger.version>
Expand Down Expand Up @@ -144,6 +146,16 @@
<artifactId>opentelemetry-semconv</artifactId>
<version>${opentelemetry-semconv.version}</version>
</dependency>
<dependency>
<groupId>com.google.cloud.opentelemetry</groupId>
<artifactId>exporter-metrics</artifactId>
<version>${opentelemetry-exporter-metrics.version}</version>
</dependency>
<dependency>
<groupId>com.google.cloud.opentelemetry</groupId>
<artifactId>shared-resourcemapping</artifactId>
<version>${opentelemetry-shared-resourcemapping.version}</version>
</dependency>

<!-- TODO: replace with opencensus-bom when available -->
<dependency>
Expand Down
Loading