fix: protobuf version not always getting set in headers

[ldetmer]

In order to maximize amount of times protobuf version is logged we have updated logic as follows:

1. First try to use protbuf RuntimeVersion which is available in protobuf 4.x
2. if not available try to read using manifest file
3. if manifest file doesn't not exist then default to "3" as we know runtime < 4

Also updated showcase test to fail in the case protobuf version is missing

Tested:

1. maven build using client library directly and overriding protobuf
2. spring boot started project + google cloud storage client client lib, validated that protobuf header was sent

[burkedavison]

LGTM. Blake for approval.

[blakeli0]

So we are going to have two different format of protobuf versions (3.x.x vs 3)? Is it going to cause issues when we try to aggregate the metrics?

[burkedavison]

There might be 3.1.2, which provides precision. But there shouldn't be any 3.x.x.

We shouldn't be providing precision (significant digits) when we don't know them. We can fix any parsing logic as necessary.

[blakeli0]

I don't think it's worth it to introduce a new public class just for unit testing in Gax. Can we move the wrapper methods to GaxProperties and make them package private?

[ldetmer]

i hope I understood what you meant. I moved the class to package private so I could continue to mock, or did you meant do not unit test this code?

[ldetmer]

I refactored to remove the wrapper class/methods at all. Let me know what you think!

[blakeli0]

Thanks, it looks good to me on the surface!

did you meant do not unit test this code

We should definitely do unit tests if possible. I see that the sonar coverage is complaining about the coverage now, can you please take a look at it and see if it makes sense?

[ldetmer]

thanks for calling out, I missed a test case! Fixed

[sonarcloud]

Quality Gate passed for 'gapic-generator-java-root'

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
91.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[sonarcloud]

Quality Gate failed for 'java_showcase_integration_tests'

Failed conditions
50.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud