Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ggj][infra][1/5] integration-test: add goldens files for Redis client library #378

Merged
merged 16 commits into from
Oct 13, 2020
Merged

[ggj][infra][1/5] integration-test: add goldens files for Redis client library #378

merged 16 commits into from
Oct 13, 2020

Conversation

xiaozhenliu-gg5
Copy link
Contributor

Find more details in design doc: go/java-micro-integration-test-infra

  1. add client library files generated from monolith generator (3 intermediary srcjars from rule) to goldens folder.
  2. add a bazel file for the goldens/redis folder.

Next Step:

[2/5] Add integration test bazel rules which will run Redis client library generation and compare Java source code with the added goldens files.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 8, 2020
miraleung
miraleung approved these changes Oct 9, 2020
View reviewed changes
Copy link
Contributor

@miraleung miraleung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a README to test/integration/goldens so that future readers will know that these are actual source Java files, but just goldens?

miraleung
miraleung suggested changes Oct 9, 2020
View reviewed changes
Copy link
Contributor

@miraleung miraleung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On second thought, let's update these goldens with the upcoming microgenerator rules.

@xiaozhenliu-gg5
Copy link
Contributor Author

On hold until the microgenerator rules are ready and update Redis goldens. @miraleung

miraleung
miraleung approved these changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@miraleung miraleung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with BUILD target comment.

test/integration/goldens/redis/BUILD.bazel Outdated Show resolved Hide resolved
@xiaozhenliu-gg5 xiaozhenliu-gg5 merged commit f0f1dd2 into master Oct 13, 2020
@xiaozhenliu-gg5 xiaozhenliu-gg5 deleted the add_redis_goldens branch October 13, 2020 06:13
suztomo pushed a commit that referenced this pull request Dec 16, 2022
@renovate-bot
deps: update dependency com.google.protobuf:protobuf-bom to v3.21.2 (#…
b773516 
…378)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.protobuf:protobuf-bom](https://developers.google.com/protocol-buffers/) ([source](https://togithub.com/protocolbuffers/protobuf)) | `3.21.1` -> `3.21.2` | [![age](https://badges.renovateapi.com/packages/maven/com.google.protobuf:protobuf-bom/3.21.2/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.protobuf:protobuf-bom/3.21.2/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.protobuf:protobuf-bom/3.21.2/compatibility-slim/3.21.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.protobuf:protobuf-bom/3.21.2/confidence-slim/3.21.1)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>protocolbuffers/protobuf</summary>

### [`v3.21.2`](https://togithub.com/protocolbuffers/protobuf/compare/v3.21.1...v3.21.2)

[Compare Source](https://togithub.com/protocolbuffers/protobuf/compare/v3.21.1...v3.21.2)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-common-protos).
suztomo pushed a commit that referenced this pull request Dec 16, 2022
@release-please
chore(main): release 2.9.1 (#381)
7a39bea 
🤖 I have created a release *beep* *boop*
---


## [2.9.1](googleapis/java-common-protos@v2.9.0...v2.9.1) (2022-06-27)


### Dependencies

* update dependency com.google.protobuf:protobuf-bom to v3.21.2 ([#378](googleapis/java-common-protos#378)) ([b773516](googleapis/java-common-protos@b773516))
* update dependency com.google.protobuf:protobuf-java to v3.21.2 ([#379](googleapis/java-common-protos#379)) ([efa0f76](googleapis/java-common-protos@efa0f76))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
suztomo pushed a commit that referenced this pull request Dec 16, 2022
@renovate-bot
deps: update dependency com.google.http-client:google-http-client-jac…
b3a88b7 
…kson2 to v1.42.1 (#378)
suztomo pushed a commit that referenced this pull request Dec 16, 2022
@renovate-bot @gcf-merge-on-green @diegomarquezp
deps: update auto-value.version to v1.10.1 (#378)
5988c5c 
Co-authored-by: gcf-merge-on-green[bot] <60162190+gcf-merge-on-green[bot]@users.noreply.github.com>
Co-authored-by: Diego Alonso Marquez Palacios <diegomarquezp@google.com>
suztomo pushed a commit that referenced this pull request Mar 21, 2023
@release-please
chore: release 1.3.1-SNAPSHOT (#378)
a61656a 
🤖 I have created a release \*beep\* \*boop\*
---
### Updating meta-information for bleeding-edge SNAPSHOT release.
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
suztomo pushed a commit that referenced this pull request Mar 21, 2023
@renovate-bot
deps: update dependency com.google.protobuf:protobuf-bom to v3.15.0 (#…
9b7c9c8 
…378)
suztomo pushed a commit that referenced this pull request Mar 21, 2023
@release-please
chore(master): release 1.94.2 (#370)
5178c57 
🤖 I have created a release \*beep\* \*boop\* 
---
### [1.94.2](https://www.github.com/googleapis/java-core/compare/v1.94.1...v1.94.2) (2021-03-01)


### Bug Fixes

* fix gcloud SDK detection on Windows ([#384](https://www.github.com/googleapis/java-core/issues/384)) ([2d8612a](https://www.github.com/googleapis/java-core/commit/2d8612ad710352a6eb9a8a87b63af3fcffbc4041)), closes [#383](https://www.github.com/googleapis/java-core/issues/383)


### Dependencies

* switch from Jackson to GSON ([#368](https://www.github.com/googleapis/java-core/issues/368)) ([924b330](https://www.github.com/googleapis/java-core/commit/924b3309426047d60b0205e0c85a04e475a35bfb))
* update dependency com.google.api-client:google-api-client-bom to v1.31.2 ([#359](https://www.github.com/googleapis/java-core/issues/359)) ([78905ad](https://www.github.com/googleapis/java-core/commit/78905adb2563979f6a688fba95d4cecb3ca92ef5))
* update dependency com.google.api:gax-bom to v1.62.0 ([c05acac](https://www.github.com/googleapis/java-core/commit/c05acac425a9533ece7ff4b67f31f36f7ed1b98d))
* update dependency com.google.api.grpc:proto-google-common-protos to v2.1.0 ([#387](https://www.github.com/googleapis/java-core/issues/387)) ([1496ead](https://www.github.com/googleapis/java-core/commit/1496eada07c3deaa888397e6e1cd779860569a84))
* update dependency com.google.api.grpc:proto-google-iam-v1 to v1.0.10 ([#392](https://www.github.com/googleapis/java-core/issues/392)) ([948c4d3](https://www.github.com/googleapis/java-core/commit/948c4d3a89b528f3875d47b311f24b6c0badf430))
* update dependency com.google.api.grpc:proto-google-iam-v1 to v1.0.5 ([#345](https://www.github.com/googleapis/java-core/issues/345)) ([5bb49ed](https://www.github.com/googleapis/java-core/commit/5bb49ed8ccf317ff21d8bd0fa055410c42487e2d))
* update dependency com.google.api.grpc:proto-google-iam-v1 to v1.0.7 ([#357](https://www.github.com/googleapis/java-core/issues/357)) ([a740db4](https://www.github.com/googleapis/java-core/commit/a740db443652890d5060e21cf4721282f76715bd))
* update dependency com.google.api.grpc:proto-google-iam-v1 to v1.0.9 ([#372](https://www.github.com/googleapis/java-core/issues/372)) ([8f663c3](https://www.github.com/googleapis/java-core/commit/8f663c3581dd429770d4d6fc6de8b79d2e862fca))
* update dependency com.google.auth:google-auth-library-bom to v0.22.2 ([#343](https://www.github.com/googleapis/java-core/issues/343)) ([322bddf](https://www.github.com/googleapis/java-core/commit/322bddfa19acffe0e6bf851a50b6c4149c3b4dbb))
* update dependency com.google.auth:google-auth-library-bom to v0.23.0 ([#364](https://www.github.com/googleapis/java-core/issues/364)) ([d68e337](https://www.github.com/googleapis/java-core/commit/d68e337727c8d2ebba34450184b9e59d3fd82b4e))
* update dependency com.google.auth:google-auth-library-bom to v0.24.0 ([#382](https://www.github.com/googleapis/java-core/issues/382)) ([42f05b8](https://www.github.com/googleapis/java-core/commit/42f05b83757e2d6ba473f30fd376add8c893d760))
* update dependency com.google.errorprone:error_prone_annotations to v2.5.1 ([#354](https://www.github.com/googleapis/java-core/issues/354)) ([40b33ce](https://www.github.com/googleapis/java-core/commit/40b33ce6a63353da7da15d7f85d62c98b1bed84c))
* update dependency com.google.guava:guava-bom to v30.1-android ([#348](https://www.github.com/googleapis/java-core/issues/348)) ([8101e23](https://www.github.com/googleapis/java-core/commit/8101e23e6fc993a051f87ac98ce589d110768dab))
* update dependency com.google.http-client:google-http-client-bom to v1.38.1 ([#358](https://www.github.com/googleapis/java-core/issues/358)) ([5714e81](https://www.github.com/googleapis/java-core/commit/5714e810872287d6645e428b8036211d072c5de7))
* update dependency com.google.http-client:google-http-client-bom to v1.39.0 ([c05acac](https://www.github.com/googleapis/java-core/commit/c05acac425a9533ece7ff4b67f31f36f7ed1b98d))
* update dependency com.google.protobuf:protobuf-bom to v3.15.0 ([#378](https://www.github.com/googleapis/java-core/issues/378)) ([9b7c9c8](https://www.github.com/googleapis/java-core/commit/9b7c9c8f243b9a827ff2b130cc936379831b22e2))
* update dependency com.google.protobuf:protobuf-bom to v3.15.1 ([#381](https://www.github.com/googleapis/java-core/issues/381)) ([ed5a302](https://www.github.com/googleapis/java-core/commit/ed5a302258980e558ae0f434ba77c22f450c9479))
* update dependency com.google.protobuf:protobuf-bom to v3.15.2 ([#385](https://www.github.com/googleapis/java-core/issues/385)) ([d01c65a](https://www.github.com/googleapis/java-core/commit/d01c65a5cbeea36eb75c2fde60fa2c6b8a0d05f6))
* update dependency com.google.protobuf:protobuf-bom to v3.15.3 ([#391](https://www.github.com/googleapis/java-core/issues/391)) ([9b4ccb7](https://www.github.com/googleapis/java-core/commit/9b4ccb7b8e8feabaf4e1add2f577653c7e006b77))
* update dependency io.grpc:grpc-bom to v1.34.1 ([#342](https://www.github.com/googleapis/java-core/issues/342)) ([60d361e](https://www.github.com/googleapis/java-core/commit/60d361e542bb9a22dd573b7a25f31a674b022ee3))
* update dependency opencensus to v0.28.0 ([c05acac](https://www.github.com/googleapis/java-core/commit/c05acac425a9533ece7ff4b67f31f36f7ed1b98d))
* update io.grpc:grpc-bom to v1.36.0 ([#389](https://www.github.com/googleapis/java-core/issues/389)) ([c05acac](https://www.github.com/googleapis/java-core/commit/c05acac425a9533ece7ff4b67f31f36f7ed1b98d))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miraleung miraleung miraleung approved these changes

@summer-ji-eng summer-ji-eng Awaiting requested review from summer-ji-eng

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xiaozhenliu-gg5 @miraleung