Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add dependencies to debugger rule. #931

Merged
merged 2 commits into from
Feb 11, 2022
Merged

Conversation

blakeli0
Copy link
Collaborator

Bazel debugger rule is not working because it's missing some runtime dependencies. Added the MAIN_DEPS to the deps of debugger rule.

@blakeli0 blakeli0 requested review from a team as code owners February 11, 2022 20:11
@blakeli0 blakeli0 requested a review from chanseokoh February 11, 2022 20:11
@codecov
Copy link

codecov bot commented Feb 11, 2022

Codecov Report

Merging #931 (1a205ec) into main (012677e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #931   +/-   ##
=======================================
  Coverage   87.37%   87.37%           
=======================================
  Files         162      162           
  Lines       16307    16307           
  Branches     1179     1179           
=======================================
  Hits        14248    14248           
  Misses       1717     1717           
  Partials      342      342           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 012677e...1a205ec. Read the comment docs.

@chanseokoh chanseokoh merged commit e5bd1a3 into main Feb 11, 2022
@chanseokoh chanseokoh deleted the add-dependency-to-debugger branch February 11, 2022 21:02
suztomo pushed a commit that referenced this pull request Dec 16, 2022
suztomo pushed a commit that referenced this pull request Mar 21, 2023
suztomo pushed a commit that referenced this pull request Mar 21, 2023
🤖 I have created a release *beep* *boop*
---


### Updating meta-information for bleeding-edge SNAPSHOT release.

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants