Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: map 504 errors to DEADLINE_EXCEEDED #663

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

tritone
Copy link
Contributor

@tritone tritone commented Aug 5, 2024

This is needed to test behavior with DEADLINE_EXCEEDED errors for gRPC. GCS is still returning these errors in some cases for internal timeouts so we need to be able to test this.

Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

  • Tests pass
  • Appropriate changes to README are included in PR

This is needed to test behavior with DEADLINE_EXCEEDED errors for gRPC.
GCS is still returning these errors in some cases for internal timeouts
so we need to be able to test this.
@tritone tritone requested a review from a team as a code owner August 5, 2024 15:37
Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.68%. Comparing base (61bce3c) to head (5e40848).
Report is 29 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #663      +/-   ##
==========================================
- Coverage   98.69%   98.68%   -0.01%     
==========================================
  Files          50       50              
  Lines        8492     8461      -31     
==========================================
- Hits         8381     8350      -31     
  Misses        111      111              
Flag Coverage Δ
unittests 98.68% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tritone tritone merged commit 6fe4bc9 into googleapis:main Aug 5, 2024
13 checks passed
@tritone tritone deleted the deadline-exceeded branch August 5, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants