Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: delete retry instruction before sleep for force stall retry #690

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

raj-prince
Copy link
Contributor

Fixes #689

  • Tests pass
  • Appropriate changes to README are included in PR

@raj-prince raj-prince requested a review from a team as a code owner October 17, 2024 08:41
@raj-prince raj-prince changed the title fix: delete retry instruction before sleep for force stall retry fix: delete retry instruction before sleep for force stall retry Oct 17, 2024
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.74%. Comparing base (61bce3c) to head (49cc149).
Report is 46 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #690      +/-   ##
==========================================
+ Coverage   98.69%   98.74%   +0.05%     
==========================================
  Files          50       50              
  Lines        8492     8753     +261     
==========================================
+ Hits         8381     8643     +262     
+ Misses        111      110       -1     
Flag Coverage Δ
unittests 98.74% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tritone tritone merged commit fe4e49c into googleapis:main Oct 17, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Force stall retry doesn't obey the planted error count
2 participants