Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to specify local googleapis directory #100

Merged
merged 3 commits into from
Oct 19, 2018

Conversation

busunkim96
Copy link
Contributor

Closes #91.

cc: @beccasaurus

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 17, 2018
Copy link
Contributor

@theacodes theacodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would you feel about leaving clone_googleapis where is it but introducing an environment variable (SYNTHTOOL_GOOGLEAPIS) to set it for all calls to {x}_library()?

@busunkim96
Copy link
Contributor Author

@theacodes So set self.googleapis to the value of the SYNTHTOOL_GOOGLEAPIS environment variable if it exists?

Another question: Should the local googleapis be used even when private=True in the _generate_code call?

@theacodes
Copy link
Contributor

theacodes commented Oct 18, 2018 via email

@busunkim96 busunkim96 merged commit 834f26c into googleapis:master Oct 19, 2018
@busunkim96 busunkim96 deleted the local-googleapis branch October 19, 2018 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants