-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(node): remove define_artifacts from Node.js's Windows kokoro build #103
Merged
JustinBeckwith
merged 1 commit into
master
from
node-remove-sponge-xml-from-windows-builds
Oct 22, 2018
Merged
fix(node): remove define_artifacts from Node.js's Windows kokoro build #103
JustinBeckwith
merged 1 commit into
master
from
node-remove-sponge-xml-from-windows-builds
Oct 22, 2018
+0
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Oct 22, 2018
This was referenced Oct 22, 2018
jkwlui
changed the title
fix(node): remove store_artifact from Node.js's Windows kokoro build
fix(node): remove define_artifacts from Node.js's Windows kokoro build
Oct 22, 2018
This was referenced Oct 22, 2018
Merged
This was referenced Oct 22, 2018
Merged
Merged
Merged
This was referenced Oct 22, 2018
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
busunkim96
approved these changes
Oct 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are not dumping test results to
sponge.xml
and it was causing issues when Kokoro tries to pull it from the VM.