-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: minimize noise from build scripts #1091
Conversation
This should limit the amount of scrolling client devs have to do when debugging a test failure
@@ -28,7 +28,6 @@ job=$(basename ${KOKORO_JOB_NAME}) | |||
echo "coercing sponge logs..." | |||
for xml in `find . -name *-sponge_log.xml` | |||
do | |||
echo "processing ${xml}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure examining the xml is never useful?
What is the cost of the current noise?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think its only useful when trying to debug the kokoro infrastructure (ie, why are my test results not showing up), which is rare. It is completely useless when trying to figure out why a new client feature broke the build.
Currently all builds have fail at end flag set, so to figure out which module broke, I need to scroll to the end of the build log for the summary. However the end of the file has a thousand lines of file paths that I dont care about, which I have to scroll up until I get to useful info. If we remove this echo my debug workflow is:
scroll to end
identify broken module
find in page for module name
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
ping |
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
1 similar comment
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
This should limit the amount of scrolling client devs have to do when debugging a test failure