Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: removing linkage-monitor from the required checks #1189

Closed
wants to merge 1 commit into from
Closed

ci: removing linkage-monitor from the required checks #1189

wants to merge 1 commit into from

Conversation

suztomo
Copy link
Member

@suztomo suztomo commented Aug 23, 2021

Linkage Monitor has served to identify the dependency conflicts
between the source tree in a pull request and the latest Libraries
BOM. However the Libraries BOM now implements the process to sync
with the dependencies of the Google Cloud BOM and the Google Cloud
BOM achieves dependency convergence with regard to the shared
dependencies BOM. Therefore, Linkage Monitor does not give much
benefit to our library development process any more.
GoogleCloudPlatform/cloud-opensource-java#2137

@suztomo
ci: removing linkage-monitor from the required checks
2e50f7d 
Linkage Monitor has served to identify the dependency conflicts
between the source tree in a pull request and the latest Libraries
BOM. However the Libraries BOM now implements the process to sync
with the dependencies of the Google Cloud BOM and the Google Cloud
BOM achieves dependency convergence with regard to the shared
dependencies BOM. Therefore, Linkage Monitor does not give much
benefit to our library development process any more.
GoogleCloudPlatform/cloud-opensource-java#2137
@suztomo suztomo requested a review from a team as a code owner August 23, 2021 20:56
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 23, 2021
@suztomo
Copy link
Member Author

suztomo commented Aug 23, 2021 •
edited
Loading

?

nox > mypy synthtool autosynth
synthtool/log.py:21: error: Cannot assign to a type
synthtool/log.py:21: error: Incompatible types in assignment (expression has type "None", variable has type "Type[ColoredFormatter]")
synthtool/log.py:71: error: Incompatible types in assignment (expression has type "Formatter", variable has type "ColoredFormatter")
Found 3 errors in 1 file (checked 47 source files)

Retrying.

@suztomo suztomo added the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 23, 2021
@suztomo suztomo closed this Aug 24, 2021
@suztomo suztomo reopened this Aug 24, 2021
@suztomo suztomo closed this Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement. kokoro:run Add this label to force Kokoro to re-run the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@suztomo