Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(python): modify templated noxfile to support non-cloud APIs #1263

Merged
merged 1 commit into from
Oct 21, 2021

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Oct 21, 2021

Currently the owlbot.py file for non-cloud APIs need to have replacements in owlbot.py in order to use the templated noxfile. See the example from python-analytics-admin here which has:

s.replace("noxfile.py",
'''["']--cov=google/cloud["'],''',
'''"--cov=google.analytics",''')

This PR eliminates the need for this replacement in owlbot.py. I tested this change in googleapis/python-orchestration-airflow#41, and googleapis/python-analytics-admin#157 and the Kokoro build passed in both.

@parthea parthea requested a review from a team as a code owner October 21, 2021 00:37
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 21, 2021
@parthea parthea requested a review from busunkim96 October 21, 2021 01:17
@parthea parthea merged commit 76d5fec into master Oct 21, 2021
@parthea parthea deleted the add-support-for-non-cloud-in-noxfile branch October 21, 2021 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants