Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(python): auto approve template changes #1431

Merged
merged 2 commits into from
May 5, 2022

Conversation

parthea
Copy link
Contributor

@parthea parthea commented May 5, 2022

This PR will allow changes from https://github.com/googleapis/synthtool/tree/master/synthtool/gcp/templates/python_library that have [autoapprove] in the synthtool PR title in to be autoapproved in downstream repos to reduce toilsome tasks.

See the criteria autoapproving under the OwlBotTemplateChanges heading here https://github.com/googleapis/repo-automation-bots/tree/main/packages/auto-approve#latest-release-notes-112321

I tested the changes in the python-access-approval repository

Here is a PR where I added auto-approve.yml:
googleapis/python-access-approval#197

Here is a PRs that shows the auto-approve feature is working:
googleapis/python-access-approval#198

@parthea parthea added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels May 5, 2022
@parthea parthea marked this pull request as ready for review May 5, 2022 21:51
@parthea parthea requested a review from a team as a code owner May 5, 2022 21:51
@parthea parthea merged commit 453a5d9 into master May 5, 2022
@parthea parthea deleted the auto-approve-template-updates branch May 5, 2022 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants