fix: add hashes to requirements.txt #1544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and update Docker images so they require hashes.
SurferJeffAtGoogle
requested review from
a team,
chingor13 and
bcoe
as code owners
|
Do you plan to fix "pip install" in other places as well? Like this one used for releasing for Java? |
Yes. |
commit ab7384e Author: Jeffrey Rennie <rennie@google.com> Date: Tue Aug 23 11:38:48 2022 -0700 fix: remove pip install statements (googleapis#1546) because the tools are already installed in the docker image as of googleapis/testing-infra-docker#227 commit 302667c Author: WhiteSource Renovate <bot@renovateapp.com> Date: Tue Aug 23 19:50:28 2022 +0200 chore(deps): update dependency setuptools to v65.2.0 (googleapis#1541) Co-authored-by: Anthonios Partheniou <partheniou@google.com> commit 6e9054f Author: WhiteSource Renovate <bot@renovateapp.com> Date: Tue Aug 23 19:42:51 2022 +0200 chore(deps): update dependency nbconvert to v7 (googleapis#1543) Co-authored-by: Anthonios Partheniou <partheniou@google.com> commit d229a12 Author: Alexander Fenster <fenster@google.com> Date: Mon Aug 22 15:04:53 2022 -0700 fix: update google-gax and remove obsolete deps (googleapis#1545) commit 13ce626 Author: Jeffrey Rennie <rennie@google.com> Date: Mon Aug 22 11:08:21 2022 -0700 chore: remove release config and script (googleapis#1540) We don't release to pypi anymore.
to move forward with other languages until Java's docker image is fixed
SurferJeffAtGoogle
force-pushed
the
requirements-txt
branch
from
e3c64df to
170d7e3
Compare
bcoe
approved these changes
Aug 23, 2022
tmatsuo
approved these changes
Aug 23, 2022
|
Oh, change for java is gone? 0a5fa67 |
Yeah, sorry. Java requires some more work upstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and update Docker images so they require hashes.