Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(php): support version string for gapics #1894

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

bshaffer
Copy link
Contributor

@bshaffer bshaffer commented Nov 6, 2023

We added version_string to allow for copying "common" protos which don't contain a version string. We can also use it when we want to copy files over at any point which isn't the version. This happens often, when we want a package to also contain builds of its sub-packages.

One example of this is in MapsFleetengine, where we want the build of google/maps/fleetengine/delivery to have tests, samples, and GAPIC src to be prefixed by the directory src/Discovery:

# "Discovery" subdirectory
MapsFleetengine/src/Discovery/V1/(Gapic Files)
MapsFleetengine/tests/Unit/Discovery/V1/(Test Files)
MapsFleetengine/samples/Discovery/V1/(Sample Files)
# The rest of the SDK
MapsFleetengine/src/V1/(Gapic Files)
MapsFleetengine/tests/Unit/V1/(Test Files)
MapsFleetengine/samples/V1/(Sample Files)

There are a few examples of this behavior, where we want to include generate GAPIC files, but we want to place them in a subdirectory. Other examples include:

@parthea parthea assigned bshaffer and unassigned chingor13 Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants