Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [java] allow passing libraries_bom_version from env #1967

Merged
merged 2 commits into from
May 17, 2024
Merged

feat: [java] allow passing libraries_bom_version from env #1967

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e9ef1d2
feat: [java] allow passing libraries_bom_version from env
diegomarquezp May 16, 2024
a2c9b4a
reformat
diegomarquezp May 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions synthtool/languages/java.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@
DEFAULT_MIN_SUPPORTED_JAVA_VERSION = 8
METADATA = "metadata"
LIBRARIES_BOM_VERSION = "libraries_bom_version"
LIBRARIES_BOM_VERSION_ENV_KEY = "SYNTHTOOL_LIBRARIES_BOM_VERSION"


def format_code(
Expand Down Expand Up @@ -501,8 +502,10 @@ def common_templates(
split_repo = not monorepo
repo_metadata = metadata["repo"]
repo_short = repo_metadata["repo_short"]
if LIBRARIES_BOM_VERSION in kwargs:
kwargs[METADATA][LIBRARIES_BOM_VERSION] = kwargs.get(LIBRARIES_BOM_VERSION)
if os.getenv(LIBRARIES_BOM_VERSION_ENV_KEY, default=None) is not None:
kwargs[METADATA][LIBRARIES_BOM_VERSION] = os.getenv(
LIBRARIES_BOM_VERSION_ENV_KEY
)
# Special libraries that are not GAPIC_AUTO but in the monorepo
special_libs_in_monorepo = [
"java-translate",
Expand Down
Loading