Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(python): use python installed by pyenv for bazel #520

Merged
merged 1 commit into from
May 4, 2020

Conversation

chingor13
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 4, 2020
@chingor13
Copy link
Contributor Author

cc @vam-google

Copy link
Contributor

@vam-google vam-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please don't merge it yet (before the corresponding change ins sync'ed to googleapis/googleapis)

@chingor13 chingor13 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 4, 2020
@vam-google
Copy link
Contributor

@chingor13 the changes are integrated into googleapis. Please push this, otherwise autosynth will fail on its next execution (will not be able to find pyenv3_toolchain).

@chingor13 chingor13 removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 4, 2020
@chingor13 chingor13 requested a review from busunkim96 May 4, 2020 22:48
@busunkim96 busunkim96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 4, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 4, 2020
@chingor13 chingor13 merged commit a2c1c4f into master May 4, 2020
@chingor13 chingor13 deleted the chingor13-patch-2 branch May 4, 2020 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants