Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(node): cleanup production deps before installing dev/production #829

Merged
merged 1 commit into from
Oct 26, 2020
Merged

build(node): cleanup production deps before installing dev/production #829

merged 1 commit into from
Oct 26, 2020

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Oct 26, 2020 •
edited
Loading

The compileProtos step throws an exception on npm i, if and only if npm i --production has been run first, see: googleapis/nodejs-secret-manager#178

This change stops generating a package-lock.json and cleans the node_modules folder, before running npm i.

I will reject the prior update to ci.yaml, and run synthtool manually Monday to land this.

@bcoe bcoe requested a review from a team as a code owner October 26, 2020 03:01
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 26, 2020
@bcoe bcoe merged commit 89c849b into master Oct 26, 2020
@bcoe bcoe deleted the cleanup-production-install branch October 26, 2020 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AVaksman AVaksman AVaksman approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bcoe @AVaksman