chore: force rebuild of node 18 image #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivial change to rebuild images
build: start with higher Cloud SDK CLI use updated python
chingor13
force-pushed
the
chingor13-patch-1
branch
from
c54505e
to
c9ad634
Compare
chingor13
changed the title
chingor13
commented
Jun 4, 2024
| @@ -71,7 +71,7 @@ RUN python3 -m pip install --require-hashes -r requirements.txt | |||
| # Setup Cloud SDK | |||
| WORKDIR /home/node | |||
| ENV CLOUD_SDK_VERSION=446.0.0 \ | |||
| CLOUDSDK_PYTHON=/usr/bin/python3 \ | |||
There was a problem hiding this comment.
System python was 3.7.x and gcloud CLI does not allow it anymore
chingor13
commented
Jun 4, 2024
Comment on lines
-18
to
-41
| # Node 12 | ||
| - name: gcr.io/cloud-builders/docker | ||
| args: ['build', '-t', 'gcr.io/cloud-devrel-kokoro-resources/node:12-user', '.'] | ||
| dir: 'node/12-user' | ||
| waitFor: ['-'] | ||
|
|
||
| # Node 14 | ||
| - name: gcr.io/cloud-builders/docker | ||
| args: ['build', '-t', 'gcr.io/cloud-devrel-kokoro-resources/node:14-user', '.'] | ||
| dir: 'node/14-user' | ||
| waitFor: ['-'] | ||
|
|
||
| # Node 16 | ||
| - name: gcr.io/cloud-builders/docker | ||
| args: ['build', '-t', 'gcr.io/cloud-devrel-kokoro-resources/node:16-user', '.'] | ||
| dir: 'node/16-user' | ||
| waitFor: ['-'] | ||
|
|
||
| # Node 16-puppeteer | ||
| - name: gcr.io/cloud-builders/docker | ||
| args: ['build', '-t', 'gcr.io/cloud-devrel-kokoro-resources/node:16-puppeteer', '.'] | ||
| dir: 'node/16-puppeteer' | ||
| waitFor: ['-'] | ||
|
|
There was a problem hiding this comment.
These node versions are all EoL and no longer build.
sofisl
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: stop building node < 18 (EoL)