Merged
Conversation
Required to run tests for this Sample: GoogleCloudPlatform/python-docs-samples#2554
grayside
approved these changes
Nov 25, 2019
Contributor
|
I've approved from a Dockerfile syntax standpoint, and because this change is in line with similar changes made for Nodejs and Go. However, I'm not clear on:
I look to @bcoe or @busunkim96 for guidance. |
bcoe
approved these changes
Nov 25, 2019
|
@dinagraves thanks for the patch 👍 glad to see more folks on this repo 😄 |
tswast
pushed a commit
to tswast/testing-infra-docker
that referenced
this pull request
Aug 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required to run tests for this Sample: GoogleCloudPlatform/python-docs-samples#2554