This repository has been archived by the owner on Mar 13, 2018. It is now read-only.
unwrap FormData in XMLHttpRequest.send if needed #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@arv mind taking a look? Even though it's smallish, I created a few new files to match the existing style. |
| var unwrapIfNeeded = scope.unwrapIfNeeded; | ||
| var XMLHttpRequest = window.XMLHttpRequest; | ||
|
|
||
| var originalSend = XMLHttpRequest && XMLHttpRequest.prototype.send; |
There was a problem hiding this comment.
You don't need to check if XMLHttpRequest is available. All browsers support it alreade.
var unwrapIfNeeded = scope.unwrapIfNeeded;
var originalSend = XMLHttpRequest.prototype.send;
|
LGTM with nits |
jmesserly
force-pushed
the
xhr_formdata
branch
from
467a422
to
383d9da
Compare
|
PTAL |
|
Great LGTM |
|
awesome, thank you! |
jmesserly
pushed a commit
that referenced
this pull request
Sep 10, 2014
unwrap FormData in XMLHttpRequest.send if needed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes Polymer/polymer#725