Skip to content
This repository has been archived by the owner on Apr 27, 2021. It is now read-only.

Commit

Permalink
Bump the version of the library, and in a possibly confusing bid
Browse files Browse the repository at this point in the history
to align versions, roll the bower version into our library version.

So ca3 > ca1.4.0.

This will allow better expression of scale in future releases.
In fact, we should consider bumping at minimum the tertiary number with
every future moe push.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=70824551
  • Loading branch information
DaddingtonPalace committed Jul 9, 2014
1 parent fe506b7 commit ea84600
Show file tree
Hide file tree
Showing 6 changed files with 5 additions and 20 deletions.
2 changes: 1 addition & 1 deletion bower.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "chrome-platform-analytics",
"version": "1.3.0",
"version": "1.4.0",
"main": "google-analytics-bundle.js",
"description": "Javascript Google Analytics (GA) client library for Chrome Platform Applications (and Extensions).",
"license": "Apache 2.0",
Expand Down
2 changes: 1 addition & 1 deletion google-analytics-bundle.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/google_analytics.js
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ goog.require('goog.structs.Map');
* major change to the library.
* @const {string}
*/
analytics.LIBRARY_VERSION = 'ca3';
analytics.LIBRARY_VERSION = 'ca1.4.0';


/** @private {string} */
Expand Down
2 changes: 1 addition & 1 deletion src/tests/google_analytics_service_test.js
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ goog.require('goog.testing.jsunit');


/** @const {string} */
var LIB_VERSION = 'ca3';
var LIB_VERSION = 'ca1.4.0';


/** @const {string} */
Expand Down
2 changes: 1 addition & 1 deletion src/tests/google_analytics_test.js
Original file line number Diff line number Diff line change
Expand Up @@ -247,5 +247,5 @@ function testSend_DeliversPayload() {
assertTrue(sent.content, goog.array.contains(entries, 'ea=Melt'));
assertTrue(sent.content, goog.array.contains(entries, 'el=Strawberry'));
assertTrue(sent.content, goog.array.contains(entries, 'ev=100'));
assertTrue(sent.content, goog.array.contains(entries, '_v=ca3'));
assertTrue(sent.content, goog.array.contains(entries, '_v=ca1.4.0'));
}
15 changes: 0 additions & 15 deletions src/tests/service_channel_test.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,21 +34,6 @@ goog.require('goog.structs.Map');
goog.require('goog.testing.jsunit');


/** @const {string} */var LIB_VERSION = 'ca3';


/** @const {string} */
var APP_NAME = 'TestApp';


/** @const {string} */
var APP_VERSION = 'egpcciddnadbknkjpmdoaiqnbcoeplja';


/** @const {string} */
var TRACKING_ID = 'UA-12344-56779';


/** @const {!analytics.internal.ParameterMap} */
var HIT_0 = new analytics.internal.ParameterMap(
analytics.internal.Parameters.SCREEN_RESOLUTION, '1024x768',
Expand Down

0 comments on commit ea84600

Please sign in to comment.