small changes so that it can be used directly in a npm pipeline

[alex-milanov]

usage in a node module

const prettify = require('code-prettify')
// default
prettify.prettyPrint();
// single use
document.querySelector('pre > code').innerHTML = prettify.prettyPrintOne('function() {console.log('foo');}');

usage in a task automation (like gulp, grunt...) for css preprocessor (like sass, less)

require('code-prettify').includePaths

then inside a sass file

@import 'prettify'

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please let us know the company's name.

[alex-milanov]

I signed it!

[googlebot]

CLAs look good, thanks!

[alex-milanov]

Just some updates.

I've successfully used my fork as a npm package (npm i -S alex-milanov/code-prettify) with browserify for a simple code editor for the slides app for a local talk I did on functional reactive javascript.

You can check:

• the repo at https://github.com/alex-milanov/first-steps-frp-js
• and demo https://alex-milanov.github.io/first-steps-frp-js

Examples of usage:

• code editor with console https://github.com/alex-milanov/first-steps-frp-js/blob/master/src/js/ui/slides/code/index.js
• the paths used in the asset pipeline https://github.com/alex-milanov/first-steps-frp-js/blob/master/bin/sass-paths.js
• in the main sass file https://github.com/alex-milanov/first-steps-frp-js/blob/master/src/sass/style.sass
• some style modification https://github.com/alex-milanov/first-steps-frp-js/blob/master/src/sass/ext/_prettify.sass

Can someone check if there are potential side effects from the changes I made so that we can merge the PR? If there are we can discuss them so that I can make the needed modifications.

//cc @amroamroamro @mikesamuel

[alex-milanov]

btw. I created a gitter chat room for my fork at https://gitter.im/alex-milanov/code-prettify (You guys could create an "official" one or join the one I created, both options work for me)

[ateev]

@alex-milanov Thanks for this ! Why isn't this merged with the original project yet ?

[alex-milanov]

@ateev beats me.

//cc @amroamroamro @mikesamuel

[googlebot]

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

[alex-milanov]

@yuschick seems you have to sign a google CLA (Contributor License Agreement).
Don't how relevant this is since this PR has been opened since Feb 18.

[mikesamuel]

I think these changes need to be made in https://github.com/google/code-prettify/blob/master/js-modules/prettify.js#L94

Please also use brackets around if bodies.

Also, please use ['...'] form so that it is closure-compiler compatible.

[alex-milanov]

Sure. I will check it out. btw. wouldn't it be more logical to have the sources in the src folder and the destination in a dist one?

[alex-milanov]

@mikesamuel also aren't these vars constants -> can we use

const PR_SHOULD_USE_CONTINUATION = true;

[mikesamuel]

Won't if(module) throw an exception if there is no global named "module".

Maybe if (typeof module !== 'undefined' && module.exports)

[alex-milanov]

Probably it shouldn't be an issue in most cases but the second one would be more consistent.

[alex-milanov]

@mikesamuel after struggling for a while with the closure compile process and stumbling upon how run_prettify is formed found a way to add node support by introducing js-modues/node_prettify.js and modifying the preprocess and copy:prettify grunt tasks.
Also pointed the main in package.json (used only in node I hope) to src/node_prettify.js
//cc @yuschick Can you confirm it also works in your setup?

[alex-milanov]

@mikesamuel I hope we won't have to wait 6 more months for a response :-)

[evolve2k]

Bump.

[evolve2k]

Looks good to me. Let's merge this in.

[mikesamuel]

Thanks for doing this. Sorry for taking so long to get back to it.

[evolve2k]

Thank you everyone!!! 🙌🎉

[evolve2k]

Any possibility of doing a new public release to help get this feature out into the wild? 🦁

[alex-milanov]

If you need help I am available