-
Notifications
You must be signed in to change notification settings - Fork 901
Remove RawGit dependency (jsDelivr+GitHack) #573
Conversation
GitHack, suffers from the same issue RawGit did, which lead to its demise. Quoting the website:
Hopefully jsDelivr is reliable enough to hard code into the source. |
I'll pull this PR locally, check that the generated sources all rebuild nicely, then be ready to merge it into master. How time sensitive is this? I'd like to post an announcement to https://groups.google.com/forum/#!forum/js-code-prettifier and give people time to read it and be ready in case there's any trouble. Ideally this change wouldn't happen over the US holidays when many people are out of the office. How does landing this change second week of January sound? |
I don't think it's time sensitive at all, just something that needs to be fixed, eventually. |
That is good. |
Is this something that can be looked into soonish? I have an app that depends on code-prettify and I'd like to know if I can upgrade it with new "official" URLs or if I should just use my own fork. |
Nudging @mikesamuel |
Sending out email to support group now. |
Announcement at https://groups.google.com/forum/#!topic/js-code-prettifier/IFHev_kLm30 Will add link to README. |
f20e152 might introduce a merge conflict with this PR since it cherrypicks this PR's changes to the README and adds a link at the top to the migration announcement. |
jsdelivr is serving version 0.1.0 of code-prettify, which still references rawgit (https://www.jsdelivr.com/package/npm/code-prettify). This is probably because there has not been an official release of this repo since this fix was merged. Is there a planned release date for code-prettify before rawgit goes away? |
I can confirm the issue. It seems jsdelivr caches things pretty much "forever", which I didn't know. I'm sorry. |
OK, so this was a bug with jsDelivr. I can confirm all files are now current and being served with: So, 7 day private, 12h shared cache. Previously was one year, immutable. Clients who got the "immutable" cached version need to purge their caches before October. |
@ncruces Will request access. Thanks for investigating. |
This removes the RawGit dependency, which is winding down (fixes #564).
PR #570 suggests using GitHack, which "functions exactly the same."
Unfortunately, #570 doesn't fix the issue where it really maters, see #564 (comment).
For the actual scripts, I used jsDelivr, which seems to have an decent backing.
Elsewhere (mostly: samples, documentation) I used GitHack, because jsDelivr does not support serving HTML content with the appropriate Content-Type.
These usages should really be moved to GitHub Pages (would fix #422).
See the next comment for why I didn't use GitHack for everything.