This repository has been archived by the owner on Mar 13, 2018. It is now read-only.
Replace hardcoded drawer width with drawerWidth attribute #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before this PR can be merged, please sign the CLA. See the CONTRIBUTING guide. |
| * @type string | ||
| * @default '256px' | ||
| */ | ||
| responsiveWidth: '256px', |
There was a problem hiding this comment.
Shouldn't it be drawerWidth?
There was a problem hiding this comment.
My mistake, corrected. Thanks.
|
CLA signed. |
|
Thanks for signing the CLA! |
|
Already added support for setting drawer width 12e1cc2. Also, this pull request will not work in ShadowDOM polyfill because of this issue Polymer/polymer#270 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple attribute/style hack to enable changing the width of the drawer panel