Add attribute 'fullWindow' #35
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/. If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits. Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name. |
|
CLA signed |
|
CLAs look good, thanks! |
| @@ -26,6 +30,11 @@ subject to an additional IP rights grant found at http://polymer.github.io/PATEN | |||
| overflow-y: auto; | |||
| } | |||
|
|
|||
| :host([fullWindow]) #mainContainer { | |||
| position: relative; | |||
| width: calc(100% - {{!drawerPanel.narrow && drawerPanel.drawerWidth}}); | |||
There was a problem hiding this comment.
bindings wont work in <style> outside of native shadow dom. You'll need to use <core-style> for something like this.
There was a problem hiding this comment.
Yes, it works with native shadow dom. It doesn't work under the polyfill (other browsers besides chrome). See Polymer/polymer#270 (comment)
There was a problem hiding this comment.
#36 should work now under the polyfill. (Hope so)
|
Left two important comments. cc @frankiefu |
The attribute 'fullWindow' can be set if
<core-scroll-header-panel>is used as a 'global' component containing all other visible components (except an optional<core-drawer-panel>!).Setting this attribute fixes issues #1, #15 and #16.
It (optionally) enables "document scroll" (see the discussion here).