Firebase not loaded exception #103
Conversation
test/not_loaded_script_test.html
Outdated
| @@ -0,0 +1,10 @@ | |||
| <!DOCTYPE html> | |||
There was a problem hiding this comment.
QQ: did you try this test w/out an HTML file at all?
There was a problem hiding this comment.
@Janamou this is the only tweak I'd like a reply to...then I'm happy to land this!
There was a problem hiding this comment.
@kevmoo Sorry, I panicked because of my bug with tests in Webstorm :/
BUT, I am solving the thing that the test will not pass on other platforms than Dartium. Because I am testing there the instance of FirebaseJsNotLoadedException via throwsA(new isInstanceOf<fb.FirebaseJsNotLoadedException>()) but compiled to JS is ReferenceError and the test will not pass.
Is there any smarter solution than test only "throws"?
There was a problem hiding this comment.
See 529f330
Seems that we don't handle this consistently between Dartium and dart2js – if you're bored you could file an issue on the SDK for this...
There was a problem hiding this comment.
@kevmoo yes, that's it, thanks! Will do an issue.
* master: Prepare to release v3.0.2 support the latest version of pkg/func Use latest Travis-CI dart tasks Latest release update
|
@kevmoo done, thx! |
|
How do you want to handle #104 ? We could call this |
|
@kevmoo and this? :-) |
|
Ah! I thought this was rolled into the other one. Wanna rebase? |
|
@kevmoo yes, can you rebase it please? Thx |
Can you please take a look @kevmoo? Issue: #97.
Thx